[SPARK-58746][INFRA] Remove a dead lsof workaround and fix stale references in release tooling - #57972
Closed
uros-b wants to merge 1 commit into
Closed
[SPARK-58746][INFRA] Remove a dead lsof workaround and fix stale references in release tooling#57972uros-b wants to merge 1 commit into
uros-b wants to merge 1 commit into
Conversation
HyukjinKwon
approved these changes
Aug 13, 2026
Member
Author
|
Thank you @HyukjinKwon! |
uros-b
added a commit
that referenced
this pull request
Aug 13, 2026
…rences in release tooling ### What changes were proposed in this pull request? Three fixes to developer and release tooling: - `dev/create-release/release-build.sh`: removes the dead `lsof` band-aid block, and fixes a typo in the usage help (`reposiotry` to `repository`). - `.github/PULL_REQUEST_TEMPLATE`: updates the `ConfigEntry.scala` path to its current location under `common/utils`. ### Why are the changes needed? The `lsof` block assigns `$LSOF` and probes for the binary, but `$LSOF` is never used anywhere in the script or in anything it sources or that calls it, so the SPARK-22377 workaround has had no effect since the Jenkins machines it targeted were retired. The PR template points contributors at `core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala`, which no longer exists; the file now lives under `common/utils`. ### Does this PR introduce _any_ user-facing change? No. Developer and release tooling only. ### How was this patch tested? No functional change. `release-build.sh` still parses (`bash -n`), `$LSOF` was confirmed to have no reference outside the removed block (including in `release-util.sh` and `do-release.sh`), and the corrected `ConfigEntry.scala` path exists on master while the old one does not. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) Closes #57972 from uros-b/devexp-stale-paths-and-dead-lsof. Authored-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> (cherry picked from commit 6b6e910) Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com>
uros-b
added a commit
that referenced
this pull request
Aug 13, 2026
…rences in release tooling ### What changes were proposed in this pull request? Three fixes to developer and release tooling: - `dev/create-release/release-build.sh`: removes the dead `lsof` band-aid block, and fixes a typo in the usage help (`reposiotry` to `repository`). - `.github/PULL_REQUEST_TEMPLATE`: updates the `ConfigEntry.scala` path to its current location under `common/utils`. ### Why are the changes needed? The `lsof` block assigns `$LSOF` and probes for the binary, but `$LSOF` is never used anywhere in the script or in anything it sources or that calls it, so the SPARK-22377 workaround has had no effect since the Jenkins machines it targeted were retired. The PR template points contributors at `core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala`, which no longer exists; the file now lives under `common/utils`. ### Does this PR introduce _any_ user-facing change? No. Developer and release tooling only. ### How was this patch tested? No functional change. `release-build.sh` still parses (`bash -n`), `$LSOF` was confirmed to have no reference outside the removed block (including in `release-util.sh` and `do-release.sh`), and the corrected `ConfigEntry.scala` path exists on master while the old one does not. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) Closes #57972 from uros-b/devexp-stale-paths-and-dead-lsof. Authored-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> (cherry picked from commit 6b6e910) Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Three fixes to developer and release tooling:
dev/create-release/release-build.sh: removes the deadlsofband-aid block, and fixes a typo in the usage help (reposiotrytorepository)..github/PULL_REQUEST_TEMPLATE: updates theConfigEntry.scalapath to its current location undercommon/utils.Why are the changes needed?
The
lsofblock assigns$LSOFand probes for the binary, but$LSOFis never used anywhere in the script or in anything it sources or that calls it, so the SPARK-22377 workaround has had no effect since the Jenkins machines it targeted were retired. The PR template points contributors atcore/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala, which no longer exists; the file now lives undercommon/utils.Does this PR introduce any user-facing change?
No. Developer and release tooling only.
How was this patch tested?
No functional change.
release-build.shstill parses (bash -n),$LSOFwas confirmed to have no reference outside the removed block (including inrelease-util.shanddo-release.sh), and the correctedConfigEntry.scalapath exists on master while the old one does not.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)