Uh oh!
There was an error while loading. Please reload this page.
[SPARK-1636][MLLIB] Move main methods to examples - #584
Conversation
AmplabJenkins
commented
Apr 28, 2014
Merged build triggered. |
AmplabJenkins
commented
Apr 28, 2014
Merged build started. |
AmplabJenkins
commented
Apr 29, 2014
Merged build finished. All automated tests passed. |
AmplabJenkins
commented
Apr 29, 2014
All automated tests passed. |
There was a problem hiding this comment.
I think ti is better to declare a main rather than extending App. It is more familiar to readers from the Java/C land.
rxin
commented
Apr 29, 2014
LGTM. If you can avoid wild card imports for some packages, that'd be great. |
AmplabJenkins
commented
Apr 29, 2014
Merged build triggered. |
AmplabJenkins
commented
Apr 29, 2014
Merged build started. |
mengxr
commented
Apr 29, 2014
Made imports explicit except |
AmplabJenkins
commented
Apr 29, 2014
Merged build triggered. |
AmplabJenkins
commented
Apr 29, 2014
Merged build started. |
AmplabJenkins
commented
Apr 29, 2014
Merged build triggered. |
AmplabJenkins
commented
Apr 29, 2014
Merged build started. |
AmplabJenkins
commented
Apr 29, 2014
Merged build finished. All automated tests passed. |
1 similar comment
AmplabJenkins
commented
Apr 29, 2014
Merged build finished. All automated tests passed. |
AmplabJenkins
commented
Apr 29, 2014
Merged build finished. |
AmplabJenkins
commented
Apr 29, 2014
All automated tests passed. |
AmplabJenkins
commented
Apr 29, 2014
All automated tests passed. |
AmplabJenkins
commented
Apr 29, 2014
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14553/ |
rxin
commented
Apr 29, 2014
Thanks. Merged! |
* `NaiveBayes` -> `SparseNaiveBayes` * `KMeans` -> `DenseKMeans` * `SVMWithSGD` and `LogisticRegerssionWithSGD` -> `BinaryClassification` * `ALS` -> `MovieLensALS` * `LinearRegressionWithSGD`, `LassoWithSGD`, and `RidgeRegressionWithSGD` -> `LinearRegression` * `DecisionTree` -> `DecisionTreeRunner` `scopt` is used for parsing command-line parameters. `scopt` has MIT license and it only depends on `scala-library`. Example help message: ~~~ BinaryClassification: an example app for binary classification. Usage: BinaryClassification [options] <input> --numIterations <value> number of iterations --stepSize <value> initial step size, default: 1.0 --algorithm <value> algorithm (SVM,LR), default: LR --regType <value> regularization type (L1,L2), default: L2 --regParam <value> regularization parameter, default: 0.1 <input> input paths to labeled examples in LIBSVM format ~~~ Author: Xiangrui Meng <meng@databricks.com> Closes#584 from mengxr/mllib-main and squashes the following commits: 7b58c60 [Xiangrui Meng] minor 6e35d7e [Xiangrui Meng] make imports explicit and fix code style c6178c9 [Xiangrui Meng] update TS PCA/SVD to use new spark-submit 6acff75 [Xiangrui Meng] use scopt for DecisionTreeRunner be86069 [Xiangrui Meng] use main instead of extending App b3edf68 [Xiangrui Meng] move DecisionTree's main method to examples 8bfaa5a [Xiangrui Meng] change NaiveBayesParams to Params fe23dcb [Xiangrui Meng] remove main from KMeans and add DenseKMeans as an example 67f4448 [Xiangrui Meng] remove main methods from linear regression algorithms and add LinearRegression example b066bbc [Xiangrui Meng] remove main from ALS and add MovieLensALS example b040f3b [Xiangrui Meng] change BinaryClassificationParams to Params 577945b [Xiangrui Meng] remove unused imports from NB 3d299bc [Xiangrui Meng] remove main from LR/SVM and add an example app for binary classification f70878e [Xiangrui Meng] remove main from NaiveBayes and add an example NaiveBayes app 01ec2cd [Xiangrui Meng] Merge branch 'master' into mllib-main 9420692 [Xiangrui Meng] add scopt to examples dependencies (cherry picked from commit 3f38334) Signed-off-by: Reynold Xin <rxin@apache.org>
* `NaiveBayes` -> `SparseNaiveBayes` * `KMeans` -> `DenseKMeans` * `SVMWithSGD` and `LogisticRegerssionWithSGD` -> `BinaryClassification` * `ALS` -> `MovieLensALS` * `LinearRegressionWithSGD`, `LassoWithSGD`, and `RidgeRegressionWithSGD` -> `LinearRegression` * `DecisionTree` -> `DecisionTreeRunner` `scopt` is used for parsing command-line parameters. `scopt` has MIT license and it only depends on `scala-library`. Example help message: ~~~ BinaryClassification: an example app for binary classification. Usage: BinaryClassification [options] <input> --numIterations <value> number of iterations --stepSize <value> initial step size, default: 1.0 --algorithm <value> algorithm (SVM,LR), default: LR --regType <value> regularization type (L1,L2), default: L2 --regParam <value> regularization parameter, default: 0.1 <input> input paths to labeled examples in LIBSVM format ~~~ Author: Xiangrui Meng <meng@databricks.com> Closesapache#584 from mengxr/mllib-main and squashes the following commits: 7b58c60 [Xiangrui Meng] minor 6e35d7e [Xiangrui Meng] make imports explicit and fix code style c6178c9 [Xiangrui Meng] update TS PCA/SVD to use new spark-submit 6acff75 [Xiangrui Meng] use scopt for DecisionTreeRunner be86069 [Xiangrui Meng] use main instead of extending App b3edf68 [Xiangrui Meng] move DecisionTree's main method to examples 8bfaa5a [Xiangrui Meng] change NaiveBayesParams to Params fe23dcb [Xiangrui Meng] remove main from KMeans and add DenseKMeans as an example 67f4448 [Xiangrui Meng] remove main methods from linear regression algorithms and add LinearRegression example b066bbc [Xiangrui Meng] remove main from ALS and add MovieLensALS example b040f3b [Xiangrui Meng] change BinaryClassificationParams to Params 577945b [Xiangrui Meng] remove unused imports from NB 3d299bc [Xiangrui Meng] remove main from LR/SVM and add an example app for binary classification f70878e [Xiangrui Meng] remove main from NaiveBayes and add an example NaiveBayes app 01ec2cd [Xiangrui Meng] Merge branch 'master' into mllib-main 9420692 [Xiangrui Meng] add scopt to examples dependencies
apache#522 got messed after i rewrote the branch hadoop_jar_name. So created a new one. Author: Bijay Bisht <bijay.bisht@gmail.com> Closesapache#584 from bijaybisht/hadoop_jar_name_on_0.9.0 and squashes the following commits: 1b6fb3c [Bijay Bisht] Ported hadoopClient jar for < 1.0.1 fix
Clean up the pre-built k8s binaries output folder which is generated in `install-k8s` role. Otherwise `kubetest` will fail due to some unknown conflicts.
NaiveBayes->SparseNaiveBayesKMeans->DenseKMeansSVMWithSGDandLogisticRegerssionWithSGD->BinaryClassificationALS->MovieLensALSLinearRegressionWithSGD,LassoWithSGD, andRidgeRegressionWithSGD->LinearRegressionDecisionTree->DecisionTreeRunnerscoptis used for parsing command-line parameters.scopthas MIT license and it only depends onscala-library.Example help message: