Uh oh!
There was an error while loading. Please reload this page.
[SPARK-59045][SQL][4.3][FOLLOWUP] Fix the subset join key test - #58460
Closed
ulysses-you wants to merge 1 commit into
Closed
[SPARK-59045][SQL][4.3][FOLLOWUP] Fix the subset join key test#58460ulysses-you wants to merge 1 commit into
ulysses-you wants to merge 1 commit into
Conversation
…nch-4.3 backport ### What changes were proposed in this pull request? Follow-up to the `branch-4.3` backport of apache#58335 (commit 0d253fe). Sets `spark.sql.sources.v2.bucketing.requireAllClusterKeysForCoPartition` to false in the `SPARK-59045: compatible transforms reduce data type with subset join keys` test, which is what every other subset test in this suite already does on this branch. ### Why are the changes needed? The backport broke this test on `branch-4.3`: ``` - SPARK-59045: compatible transforms reduce data type with subset join keys *** FAILED *** List(Exchange hashpartitioning(id#L, 5), ENSURE_REQUIREMENTS, ...) was not empty storage-partitioned join should not shuffle ``` On `master` the test plans without the config because SPARK-58558 relaxed `createKeyedShuffleSpec` from requiring the partition keys to exactly match the join keys to requiring them to cover the join keys. SPARK-58558 is not on this branch, so with the config at its default `createKeyedShuffleSpec` refuses the subset shape, both sides are shuffled, and the no-shuffle assertion fails. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The failing test now passes; ran `KeyGroupedPartitioningSuite`. ### Was this patch authored or co-authored using generative AI tooling? Yes. Generated-by: Claude Code.
pan3793
approved these changes
Sep 2, 2026
peter-toth
approved these changes
Sep 2, 2026
peter-toth pushed a commit
that referenced
this pull request
Sep 2, 2026
### What changes were proposed in this pull request? Follow-up to the `branch-4.3` backport of #58335 (commit 0d253fe). Sets `spark.sql.sources.v2.bucketing.requireAllClusterKeysForCoPartition` to false in the `SPARK-59045: compatible transforms reduce data type with subset join keys` test, which is what every other subset test in this suite already does on this branch. ### Why are the changes needed? The backport broke this test on `branch-4.3`: ``` - SPARK-59045: compatible transforms reduce data type with subset join keys *** FAILED *** List(Exchange hashpartitioning(id#L, 5), ENSURE_REQUIREMENTS, ...) was not empty storage-partitioned join should not shuffle ``` On `master` the test plans without the config because SPARK-58558 relaxed `createKeyedShuffleSpec` from requiring the partition keys to exactly match the join keys to requiring them to cover the join keys. SPARK-58558 is not on this branch, so with the config at its default `createKeyedShuffleSpec` refuses the subset shape, both sides are shuffled, and the no-shuffle assertion fails. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The failing test now passes; ran `KeyGroupedPartitioningSuite`. ### Was this patch authored or co-authored using generative AI tooling? Yes. Generated-by: Claude Code. Closes#58460 from ulysses-you/spj-reducer-4.3. Authored-by: Xiduo You <ulyssesyou18@gmail.com> Signed-off-by: Peter Toth <peter.toth@gmail.com>
peter-toth
commented
Sep 2, 2026
Contributor
Merge Summary:
Posted by |
peter-toth
commented
Sep 2, 2026
Contributor
Thank you @ulysses-you for the quick fix and @pan3793 for the review. @HeartSaVioR, 4.3 CI should be unblocked now. |
HeartSaVioR
commented
Sep 2, 2026
Contributor
Thanks for the quick turnaround! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow-up to the
branch-4.3backport of #58335 (commit 0d253fe). Setsspark.sql.sources.v2.bucketing.requireAllClusterKeysForCoPartitionto false in theSPARK-59045: compatible transforms reduce data type with subset join keystest, which is what every other subset test in this suite already does on this branch.Why are the changes needed?
The backport broke this test on
branch-4.3:On
masterthe test plans without the config because SPARK-58558 relaxedcreateKeyedShuffleSpecfrom requiring the partition keys to exactly match the join keys to requiring them to cover the join keys. SPARK-58558 is not on this branch, so with the config at its defaultcreateKeyedShuffleSpecrefuses the subset shape, both sides are shuffled, and the no-shuffle assertion fails.Does this PR introduce any user-facing change?
No.
How was this patch tested?
The failing test now passes; ran
KeyGroupedPartitioningSuite.Was this patch authored or co-authored using generative AI tooling?
Yes. Generated-by: Claude Code.