Uh oh!
There was an error while loading. Please reload this page.
[WebUI] Remove debug feature for vis.js - #5994
Conversation
AmplabJenkins
commented
May 8, 2015
Merged build triggered. |
AmplabJenkins
commented
May 8, 2015
Merged build started. |
SparkQA
commented
May 8, 2015
Test build #32168 has started for PR 5994 at commit |
SparkQA
commented
May 8, 2015
Test build #32168 has finished for PR 5994 at commit
|
AmplabJenkins
commented
May 8, 2015
Merged build finished. Test FAILed. |
AmplabJenkins
commented
May 8, 2015
Test FAILed. |
sarutak
commented
May 8, 2015
retest this please. |
AmplabJenkins
commented
May 8, 2015
Merged build triggered. |
AmplabJenkins
commented
May 8, 2015
Merged build started. |
SparkQA
commented
May 8, 2015
Test build #32170 has started for PR 5994 at commit |
JoshRosen
commented
May 8, 2015
This won't actually save any space in the repo, since the old bits are going to stay around in the Git history. And it shouldn't make a difference for page load times? If that's the case, is there an issue with leaving it as-is? |
sarutak
commented
May 8, 2015
@JoshRosen Thanks for your comment. But in #5947, thare is a suggestion that including |
andrewor14
commented
May 8, 2015
Yeah right now it actually causes a JS error if you open the developer console because |
SparkQA
commented
May 8, 2015
Test build #32170 has finished for PR 5994 at commit
|
AmplabJenkins
commented
May 8, 2015
Merged build finished. Test PASSed. |
AmplabJenkins
commented
May 8, 2015
Test PASSed. |
JoshRosen
commented
May 8, 2015
SGTM. @andrewor14, want to merge this? |
andrewor14
commented
May 8, 2015
Ok. Master 1.4. |
`vis.min.js` refers `vis.map` and this even refers `vis.js` which is used for debug `vis.js` but this debug feature is not needed for Spark itself. This issue is really minor so I don't file this in JIRA. /CC andrewor14 Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp> Closes#5994 from sarutak/remove-debug-feature-for-vis and squashes the following commits: 8be038f [Kousuke Saruta] Remove vis.map entry from .rat-exclude 7404945 [Kousuke Saruta] Removed debug feature for vis.js (cherry picked from commit c45c09b) Signed-off-by: Andrew Or <andrew@databricks.com>
`vis.min.js` refers `vis.map` and this even refers `vis.js` which is used for debug `vis.js` but this debug feature is not needed for Spark itself. This issue is really minor so I don't file this in JIRA. /CC andrewor14 Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp> Closesapache#5994 from sarutak/remove-debug-feature-for-vis and squashes the following commits: 8be038f [Kousuke Saruta] Remove vis.map entry from .rat-exclude 7404945 [Kousuke Saruta] Removed debug feature for vis.js
`vis.min.js` refers `vis.map` and this even refers `vis.js` which is used for debug `vis.js` but this debug feature is not needed for Spark itself. This issue is really minor so I don't file this in JIRA. /CC andrewor14 Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp> Closesapache#5994 from sarutak/remove-debug-feature-for-vis and squashes the following commits: 8be038f [Kousuke Saruta] Remove vis.map entry from .rat-exclude 7404945 [Kousuke Saruta] Removed debug feature for vis.js
`vis.min.js` refers `vis.map` and this even refers `vis.js` which is used for debug `vis.js` but this debug feature is not needed for Spark itself. This issue is really minor so I don't file this in JIRA. /CC andrewor14 Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp> Closesapache#5994 from sarutak/remove-debug-feature-for-vis and squashes the following commits: 8be038f [Kousuke Saruta] Remove vis.map entry from .rat-exclude 7404945 [Kousuke Saruta] Removed debug feature for vis.js
vis.min.jsrefersvis.mapand this even refersvis.jswhich is used for debugvis.jsbut this debug feature is not needed for Spark itself.This issue is really minor so I don't file this in JIRA.
/CC @andrewor14