Uh oh!
There was an error while loading. Please reload this page.
[SPARK-1685] Cancel retryTimer on restart of Worker or AppClient - #602
Closed
markhamstra wants to merge 2 commits into
Closed
[SPARK-1685] Cancel retryTimer on restart of Worker or AppClient#602markhamstra wants to merge 2 commits into
markhamstra wants to merge 2 commits into
Conversation
AmplabJenkins
commented
Apr 30, 2014
Merged build triggered. |
AmplabJenkins
commented
Apr 30, 2014
Merged build started. |
Contributor
There was a problem hiding this comment.
Maybe we could rename this to something like "registrationRetryTimer" since wider scope makes this unclear otherwise.
ContributorAuthor
There was a problem hiding this comment.
Good idea. I'll update.
aarondav
commented
Apr 30, 2014
Contributor
One minor comment, other than that this looks good to me. Nice catch! I never know if our actors are actually restartable (or when they restart, for that matter)... |
markhamstra
commented
Apr 30, 2014
ContributorAuthor
+1 On the "Is it really restartable?" comment. I spent a little time today looking and trying to answer that question for all of our actors. I had to quit when I got too scared! I'm pretty confident about the DAGScheduler post-#186, but for the rest, not so much. |
AmplabJenkins
commented
Apr 30, 2014
Merged build triggered. |
AmplabJenkins
commented
Apr 30, 2014
Merged build started. |
AmplabJenkins
commented
Apr 30, 2014
Merged build finished. All automated tests passed. |
AmplabJenkins
commented
Apr 30, 2014
All automated tests passed. |
AmplabJenkins
commented
Apr 30, 2014
Merged build finished. All automated tests passed. |
AmplabJenkins
commented
Apr 30, 2014
All automated tests passed. |
mateiz
commented
May 6, 2014
Contributor
Merged this, thanks. |
asfgit pushed a commit
that referenced
this pull request
May 6, 2014
See https://issues.apache.org/jira/browse/SPARK-1685 for a more complete description, but in essence: If the Worker or AppClient actor restarts before successfully registering with Master, multiple retryTimers will be running, which will lead to less than the full number of registration retries being attempted before the new actor is forced to give up. Author: Mark Hamstra <markhamstra@gmail.com> Closes#602 from markhamstra/SPARK-1685 and squashes the following commits: 11cc088 [Mark Hamstra] retryTimer -> registrationRetryTimer 69c348c [Mark Hamstra] Cancel retryTimer on restart of Worker or AppClient
asfgit pushed a commit
that referenced
this pull request
May 6, 2014
See https://issues.apache.org/jira/browse/SPARK-1685 for a more complete description, but in essence: If the Worker or AppClient actor restarts before successfully registering with Master, multiple retryTimers will be running, which will lead to less than the full number of registration retries being attempted before the new actor is forced to give up. Author: Mark Hamstra <markhamstra@gmail.com> Closes#602 from markhamstra/SPARK-1685 and squashes the following commits: 11cc088 [Mark Hamstra] retryTimer -> registrationRetryTimer 69c348c [Mark Hamstra] Cancel retryTimer on restart of Worker or AppClient (cherry picked from commit fbfe69d) Signed-off-by: Matei Zaharia <matei@databricks.com>
markhamstra added a commit
to markhamstra/spark
that referenced
this pull request
May 14, 2014
See https://issues.apache.org/jira/browse/SPARK-1685 for a more complete description, but in essence: If the Worker or AppClient actor restarts before successfully registering with Master, multiple retryTimers will be running, which will lead to less than the full number of registration retries being attempted before the new actor is forced to give up. Author: Mark Hamstra <markhamstra@gmail.com> Closesapache#602 from markhamstra/SPARK-1685 and squashes the following commits: 11cc088 [Mark Hamstra] retryTimer -> registrationRetryTimer 69c348c [Mark Hamstra] Cancel retryTimer on restart of Worker or AppClient Conflicts: core/src/main/scala/org/apache/spark/deploy/client/AppClient.scala core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala
pdeyhim pushed a commit
to pdeyhim/spark-1
that referenced
this pull request
Jun 25, 2014
See https://issues.apache.org/jira/browse/SPARK-1685 for a more complete description, but in essence: If the Worker or AppClient actor restarts before successfully registering with Master, multiple retryTimers will be running, which will lead to less than the full number of registration retries being attempted before the new actor is forced to give up. Author: Mark Hamstra <markhamstra@gmail.com> Closesapache#602 from markhamstra/SPARK-1685 and squashes the following commits: 11cc088 [Mark Hamstra] retryTimer -> registrationRetryTimer 69c348c [Mark Hamstra] Cancel retryTimer on restart of Worker or AppClient
bzhaoopenstack pushed a commit
to bzhaoopenstack/spark
that referenced
this pull request
Sep 11, 2019
agirish pushed a commit
to HPEEzmeral/apache-spark
that referenced
this pull request
May 5, 2022
* K8S-1087 - mount metrics_ticket implicitly to spark pods from mapr-server-secrets * K8S-1087 - fix tickets mounting conflict - move unnecessary config values to constants
udaynpusa pushed a commit
to mapr/spark
that referenced
this pull request
Jan 30, 2024
* K8S-1087 - mount metrics_ticket implicitly to spark pods from mapr-server-secrets * K8S-1087 - fix tickets mounting conflict - move unnecessary config values to constants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/SPARK-1685 for a more complete description, but in essence: If the Worker or AppClient actor restarts before successfully registering with Master, multiple retryTimers will be running, which will lead to less than the full number of registration retries being attempted before the new actor is forced to give up.