Uh oh!
There was an error while loading. Please reload this page.
[SPARK-6784] [SQL] Clean up all the inbound/outbound conversions for DateType - #6027
[SPARK-6784] [SQL] Clean up all the inbound/outbound conversions for DateType#6027scwf wants to merge 4 commits into
Conversation
AmplabJenkins
commented
May 9, 2015
Merged build triggered. |
AmplabJenkins
commented
May 9, 2015
Merged build started. |
SparkQA
commented
May 9, 2015
Test build #32301 has started for PR 6027 at commit |
SparkQA
commented
May 9, 2015
Test build #32301 has finished for PR 6027 at commit
|
AmplabJenkins
commented
May 9, 2015
Merged build finished. Test PASSed. |
AmplabJenkins
commented
May 9, 2015
Test PASSed. |
marmbrus
commented
May 9, 2015
Sorry for the confusion, but this JIRA was not about adding methods for mutating data columns, but fixing places in the execution engine where you could get errors because the types are not handled correctly. |
AmplabJenkins
commented
May 10, 2015
Merged build triggered. |
AmplabJenkins
commented
May 10, 2015
Merged build started. |
SparkQA
commented
May 10, 2015
Test build #32319 has started for PR 6027 at commit |
scwf
commented
May 10, 2015
@marmbrus, thanks your explain. But after i go through the DateType related code i think we have converted date type to int when execution. |
marmbrus
commented
May 10, 2015
You are correct that most of the places have been converted but there are still some mistakes. For example, I believe date columns in partitioning columns. JDBC was also doing the conversion wrong when the ticket was opened, but I believe that has been fixed now. |
SparkQA
commented
May 10, 2015
Test build #32319 has finished for PR 6027 at commit
|
AmplabJenkins
commented
May 10, 2015
Merged build finished. Test FAILed. |
AmplabJenkins
commented
May 10, 2015
Test FAILed. |
scwf
commented
May 11, 2015
For date columns in partitioning columns, should i start this work after #5526 is in, right? |
marmbrus
commented
May 11, 2015
Check with @adrian-wang who might be working on the partitioning column issue already. |
adrian-wang
commented
May 11, 2015
For the idea of |
scwf
commented
May 14, 2015
i am closing this |
/cc @yhuai and @davies