Skip to content

[SQL][minor] use private[this] for internal field in ScalaUdf - #6235

Closed
cloud-fan wants to merge 1 commit into
apache:masterfrom
cloud-fan:tmp
Closed

[SQL][minor] use private[this] for internal field in ScalaUdf#6235
cloud-fan wants to merge 1 commit into
apache:masterfrom
cloud-fan:tmp

Conversation

@cloud-fan

@cloud-fancloud-fan commented May 18, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@AmplabJenkins

AmplabJenkins commented May 18, 2015

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

AmplabJenkins commented May 18, 2015

Copy link
Copy Markdown

Merged build started.

@SparkQA

SparkQA commented May 18, 2015

Copy link
Copy Markdown

Test build #32993 has started for PR 6235 at commit 6ee4641.

@SparkQA

SparkQA commented May 18, 2015

Copy link
Copy Markdown

Test build #32993 has finished for PR 6235 at commit 6ee4641.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

AmplabJenkins commented May 18, 2015

Copy link
Copy Markdown

Merged build finished. Test FAILed.

@AmplabJenkins

AmplabJenkins commented May 18, 2015

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32993/
Test FAILed.

@cloud-fancloud-fan changed the title [SQL][minor] do not use lazy val for converters in ScalaUdf[SQL][minor] use private[this] for internal field in ScalaUdfMay 18, 2015
@AmplabJenkins

AmplabJenkins commented May 18, 2015

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

AmplabJenkins commented May 18, 2015

Copy link
Copy Markdown

Merged build started.

@SparkQA

SparkQA commented May 18, 2015

Copy link
Copy Markdown

Test build #32994 has started for PR 6235 at commit 8f16367.

@SparkQA

SparkQA commented May 18, 2015

Copy link
Copy Markdown

Test build #32994 has finished for PR 6235 at commit 8f16367.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins

AmplabJenkins commented May 18, 2015

Copy link
Copy Markdown

Merged build finished. Test PASSed.

@AmplabJenkins

AmplabJenkins commented May 18, 2015

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32994/
Test PASSed.

asfgit pushed a commit that referenced this pull request May 18, 2015
@cloud-fan@marmbrus
[SQL] [MINOR] [THIS] use private for internal field in ScalaUdf
7d44c01
Author: Wenchen Fan <cloud0fan@outlook.com>
Closes#6235 from cloud-fan/tmp and squashes the following commits:
8f16367 [Wenchen Fan] use private[this]
(cherry picked from commit 56ede88)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@marmbrus

marmbrus commented May 18, 2015

Copy link
Copy Markdown
Contributor

Merged to master and 1.4

@cloud-fan
cloud-fan deleted the tmp branch May 19, 2015 05:06
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@cloud-fan@jeanlyn
[SQL] [MINOR] [THIS] use private for internal field in ScalaUdf
b02e176
Author: Wenchen Fan <cloud0fan@outlook.com>
Closesapache#6235 from cloud-fan/tmp and squashes the following commits:
8f16367 [Wenchen Fan] use private[this]
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@cloud-fan@jeanlyn
[SQL] [MINOR] [THIS] use private for internal field in ScalaUdf
9476505
Author: Wenchen Fan <cloud0fan@outlook.com>
Closesapache#6235 from cloud-fan/tmp and squashes the following commits:
8f16367 [Wenchen Fan] use private[this]
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@cloud-fan@nemccarthy
[SQL] [MINOR] [THIS] use private for internal field in ScalaUdf
0c7d415
Author: Wenchen Fan <cloud0fan@outlook.com>
Closesapache#6235 from cloud-fan/tmp and squashes the following commits:
8f16367 [Wenchen Fan] use private[this]
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cloud-fan@AmplabJenkins@SparkQA@marmbrus