[SPARK-7717][WebUI] Only showing total memory and cores for alive workers

[zhichao-li]

No description provided.

[SparkQA]

Test build #33238 has finished for PR 6317 at commit 1e8eb06.

• This patch fails PySpark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

Although it seems reasonable, isn't the table listing all workers regardless of state? I wonder if it's more confusing that the table won't sum to the total. Would it be better to explicitly say "Alive Workers", "Cores in use", "Memory in use" to be clear?

[andrewor14]

@zhichao-li can you attach screenshots describing what it looks like before and after your change?

[zhichao-li]

Before :

After :

[srowen]

Nit: extra space at the end.

@zhichao-li I'm OK with this change but if the UI then changes to clarify that the metrics are only for alive workers. Otherwise it introduces a smaller new confusion.

OK with that @andrewor14

[zhichao-li]

@srowen "Alive" prefix has been added to the Worker, Cores and Memory. :)

[SparkQA]

Test build #33486 has finished for PR 6317 at commit 99b6768.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

I don't think "Alive Memory" / "Alive Cores" makes sense. "Memory in use" / "Cores in use"?

[SparkQA]

Test build #33508 has finished for PR 6317 at commit d68bf11.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

What do you think @andrewor14 ? I do think it makes a bit more sense to report active workers only.

[srowen]

I think this change is an improvement and low-impact in any event, so will put it in to master

[andrewor14]

Sorry for the late response, lgtm too