Uh oh!
There was an error while loading. Please reload this page.
[SPARK-8200] [MLlib] Check for empty RDDs in StreamingLinearAlgorithm - #6713
Closed
pparkkin wants to merge 5 commits into
Closed
[SPARK-8200] [MLlib] Check for empty RDDs in StreamingLinearAlgorithm#6713pparkkin wants to merge 5 commits into
pparkkin wants to merge 5 commits into
Conversation
srowen
commented
Jun 9, 2015
Member
@pparkkin please review https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark Among other things this needs an actual title. |
Member
There was a problem hiding this comment.
Use !rdd.isEmpty as it will be notably faster.
pparkkin
commented
Jun 9, 2015
ContributorAuthor
Thanks for the quick review and comments! Sorry about not following the guide completely. I updated the PR title and description. I'll make the code changes when I get back to work tomorrow morning. |
srowen
commented
Jun 9, 2015
Member
Sorry, I merged another PR to fix the superfluous match construct here. You may need a rebase too now. |
pparkkinforce-pushed
the
streamingmodel-empty-rdd
branch
from
June 9, 2015 22:49
e3e358f to
54ad89eComparepparkkin
commented
Jun 9, 2015
ContributorAuthor
Done. |
srowen
commented
Jun 10, 2015
Member
OK to test |
srowen
commented
Jun 10, 2015
Member
Jenkins, test this please |
SparkQA
commented
Jun 10, 2015
Test build #34587 has finished for PR 6713 at commit
|
SparkQA
commented
Jun 10, 2015
Test build #894 timed out for PR 6713 at commit |
Member
There was a problem hiding this comment.
(no need for toString here but don't worry about it)
srowen
commented
Jun 10, 2015
Member
Is this ready -- just checking since there is [WIP] in the title. |
pparkkin
commented
Jun 10, 2015
ContributorAuthor
Changed title. |
asfgit pushed a commit
that referenced
this pull request
Jun 10, 2015
Test cases for both StreamingLinearRegression and StreamingLogisticRegression, and code fix. Edit: This contribution is my original work and I license the work to the project under the project's open source license. Author: Paavo <pparkkin@gmail.com> Closes#6713 from pparkkin/streamingmodel-empty-rdd and squashes the following commits: ff5cd78 [Paavo] Update strings to use interpolation. db234cf [Paavo] Use !rdd.isEmpty. 54ad89e [Paavo] Test case for empty stream. 393e36f [Paavo] Ignore empty RDDs. 0bfc365 [Paavo] Test case for empty stream. (cherry picked from commit b928f54) Signed-off-by: Sean Owen <sowen@cloudera.com>
nemccarthy pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
Test cases for both StreamingLinearRegression and StreamingLogisticRegression, and code fix. Edit: This contribution is my original work and I license the work to the project under the project's open source license. Author: Paavo <pparkkin@gmail.com> Closesapache#6713 from pparkkin/streamingmodel-empty-rdd and squashes the following commits: ff5cd78 [Paavo] Update strings to use interpolation. db234cf [Paavo] Use !rdd.isEmpty. 54ad89e [Paavo] Test case for empty stream. 393e36f [Paavo] Ignore empty RDDs. 0bfc365 [Paavo] Test case for empty stream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test cases for both StreamingLinearRegression and StreamingLogisticRegression, and code fix.
Edit:
This contribution is my original work and I license the work to the project under the project's open source license.