Uh oh!
There was an error while loading. Please reload this page.
[SPARK-8511][pyspark] Modify a test to remove a saved model in regression.py - #6926
Closed
yu-iskw wants to merge 2 commits into
Closed
[SPARK-8511][pyspark] Modify a test to remove a saved model in regression.py#6926yu-iskw wants to merge 2 commits into
regression.py#6926yu-iskw wants to merge 2 commits into
Conversation
SparkQA
commented
Jun 21, 2015
Test build #35401 has finished for PR 6926 at commit
|
yu-iskw
commented
Jun 21, 2015
ContributorAuthor
Jenkins, test this please. |
jkbradley
commented
Jun 21, 2015
Member
This actually appears in even more places in MLlib. Would you mind fixing those too with this JIRA/PR? Thanks for catching this issue! |
yu-iskw
commented
Jun 21, 2015
ContributorAuthor
@jkbradley sure! will do! |
SparkQA
commented
Jun 21, 2015
Test build #35405 has finished for PR 6926 at commit
|
…ngs, instead of `os.removedirs()`
SparkQA
commented
Jun 21, 2015
Test build #35412 has finished for PR 6926 at commit
|
yu-iskw
commented
Jun 22, 2015
ContributorAuthor
Jenkins, test this please. |
jkbradley
commented
Jun 22, 2015
Member
LGTM pending tests |
yu-iskw
commented
Jun 22, 2015
ContributorAuthor
@jkbradley Thank you for reviewing it! |
SparkQA
commented
Jun 22, 2015
Test build #35434 has finished for PR 6926 at commit
|
AmplabJenkins
commented
Jun 22, 2015
Merged build finished. Test FAILed. |
jkbradley
commented
Jun 22, 2015
Member
The tests passed, but posting here failed. I'll merge with master and branch-1.4 |
asfgit pushed a commit
that referenced
this pull request
Jun 22, 2015
…ession.py` [[SPARK-8511] Modify a test to remove a saved model in `regression.py` - ASF JIRA](https://issues.apache.org/jira/browse/SPARK-8511) Author: Yu ISHIKAWA <yuu.ishikawa@gmail.com> Closes#6926 from yu-iskw/SPARK-8511 and squashes the following commits: 7cd0948 [Yu ISHIKAWA] Use `shutil.rmtree()` to temporary directories for saving model testings, instead of `os.removedirs()` 4a01c9e [Yu ISHIKAWA] [SPARK-8511][pyspark] Modify a test to remove a saved model in `regression.py` (cherry picked from commit 5d89d9f) Signed-off-by: Joseph K. Bradley <joseph@databricks.com> Conflicts: python/pyspark/mllib/tests.py
yu-iskw
commented
Jun 22, 2015
ContributorAuthor
@jkbradley thank you for merging it! |
nemccarthy pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 22, 2015
…ession.py` [[SPARK-8511] Modify a test to remove a saved model in `regression.py` - ASF JIRA](https://issues.apache.org/jira/browse/SPARK-8511) Author: Yu ISHIKAWA <yuu.ishikawa@gmail.com> Closesapache#6926 from yu-iskw/SPARK-8511 and squashes the following commits: 7cd0948 [Yu ISHIKAWA] Use `shutil.rmtree()` to temporary directories for saving model testings, instead of `os.removedirs()` 4a01c9e [Yu ISHIKAWA] [SPARK-8511][pyspark] Modify a test to remove a saved model in `regression.py` (cherry picked from commit 5d89d9f) Signed-off-by: Joseph K. Bradley <joseph@databricks.com> Conflicts: python/pyspark/mllib/tests.py
animeshbaranawal pushed a commit
to animeshbaranawal/spark
that referenced
this pull request
Jun 25, 2015
…ession.py` [[SPARK-8511] Modify a test to remove a saved model in `regression.py` - ASF JIRA](https://issues.apache.org/jira/browse/SPARK-8511) Author: Yu ISHIKAWA <yuu.ishikawa@gmail.com> Closesapache#6926 from yu-iskw/SPARK-8511 and squashes the following commits: 7cd0948 [Yu ISHIKAWA] Use `shutil.rmtree()` to temporary directories for saving model testings, instead of `os.removedirs()` 4a01c9e [Yu ISHIKAWA] [SPARK-8511][pyspark] Modify a test to remove a saved model in `regression.py`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[SPARK-8511] Modify a test to remove a saved model in
regression.py- ASF JIRA