Uh oh!
There was an error while loading. Please reload this page.
[SPARK-8344] Add message processing time metric to DAGScheduler - #7002
Closed
JoshRosen wants to merge 2 commits into
Closed
[SPARK-8344] Add message processing time metric to DAGScheduler#7002JoshRosen wants to merge 2 commits into
JoshRosen wants to merge 2 commits into
Conversation
JoshRosen
commented
Jun 24, 2015
ContributorAuthor
/cc @kayousterhout or @markhamstra |
JoshRosen
commented
Jun 24, 2015
ContributorAuthor
@aarondav, this is the metric that I mentioned. |
SparkQA
commented
Jun 25, 2015
Test build #35733 has finished for PR 7002 at commit
|
kayousterhout
commented
Jun 25, 2015
Contributor
LGTM! |
JoshRosen
commented
Jun 26, 2015
ContributorAuthor
I'm going to merge this into master. Thanks! |
akashsethi24
commented
Oct 16, 2018
@JoshRosen@kayousterhout I Know this is old PR but I just want to know for messageProcessingTime value like mean, mean_rate are calculated and shown for each fresh batch or aggregated with the old mean and mean_rate? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new metric,
messageProcessingTime, to the DAGScheduler metrics source. This metrics tracks the time taken to process messages in the scheduler's event processing loop, which is a helpful debugging aid for diagnosing performance issues in the scheduler (such as SPARK-4961).In order to do this, I moved the creation of the DAGSchedulerSource metrics source into DAGScheduler itself, similar to how MasterSource is created and registered in Master.