Uh oh!
There was an error while loading. Please reload this page.
[SPARK-8679][SQL] remove dummy java class BaseRow and BaseMutableRow - #7059
[SPARK-8679][SQL] remove dummy java class BaseRow and BaseMutableRow#7059cloud-fan wants to merge 1 commit into
Conversation
cloud-fan
commented
Jun 27, 2015
I can take over the following internal/external row splitting job if @davies is too busy recently. Some thoughts about future plans:
|
davies
commented
Jun 27, 2015
@cloud-fan Thanks for looking into this, We have some offline discussion last week, because of the data source API, we have to make InternalRow can be casted into Row for performance, if we don't change the data source API much. So, we still need to make InternalRow as child of Row, so abort the #6869. I like the idea of removing BaseMutableRow, will merging these into #7003, if you don't mind. Just came back from retreat, will update that PR soon. |
AmplabJenkins
commented
Jun 27, 2015
Merged build triggered. |
AmplabJenkins
commented
Jun 27, 2015
Merged build started. |
SparkQA
commented
Jun 27, 2015
Test build #35895 has started for PR 7059 at commit |
SparkQA
commented
Jun 27, 2015
Test build #35895 has finished for PR 7059 at commit
|
AmplabJenkins
commented
Jun 27, 2015
Merged build finished. Test FAILed. |
cloud-fan
commented
Jun 28, 2015
closing in favor of #7003 |
we can use
abstract classinstead oftraitforMutableRow, and remove the dummy java row classes. This PR also contains some small cleanup.I keep primitive type order as "boolean, byte, short, int, long, float, double", is this conventional?