[SPARK-1841]: update scalatest to version 2.1.5 by witgo · Pull Request #713 · apache/spark

witgo · 2014-05-09T09:28:20Z

No description provided.

AmplabJenkins · 2014-05-09T09:32:58Z

Can one of the admins verify this patch?

pwendell · 2014-05-16T05:10:49Z

Jenkins, test this please (I think there are some code style issues here).

AmplabJenkins · 2014-05-16T05:12:59Z

Build triggered.

AmplabJenkins · 2014-05-16T05:13:07Z

Build started.

AmplabJenkins · 2014-05-16T05:23:12Z

Build finished.

AmplabJenkins · 2014-05-16T05:23:13Z

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15043/

witgo · 2014-05-16T05:38:09Z

@pwendell
Code style issues has been fixed

ktham · 2014-06-04T22:38:55Z

Can we get this merged soon?

pwendell · 2014-06-04T22:50:48Z

@ktham hey could you explain what features you are interest in? The dependency graph of Spark is pretty complicated so we try to defend any updates by at least having an idea of what new features they are providing. This patch and associated JIRA don't mention any specific features.

ktham · 2014-06-04T23:05:11Z

@pwendell that is of course a fair stance which I understand.

Regarding the scalatest library, there were a lot of changes in the 2.x release, but most of the existing 1.x tests should still run with scalatest 2.1.5. In particular, what's noteworthy mainly that I would like to see this in is that they have a build for Scala 2.11. The rationale being that we will eventually want to cross compile with Scala 2.11, which means its inevitable that we will in anyways be required to raise this dependency version so long as we wish to use scalatest as our testing framework. That's an unfortunate drawback when depending on a scala library, that we must also depend on when they build for a particular Scala version :-(

So long as the test suite all passes, is there any reason why we would not want to bump scalatest up?

rxin · 2014-06-06T06:40:14Z

Jenkins, add to whitelist.

AmplabJenkins · 2014-06-06T06:42:51Z

Build triggered.

AmplabJenkins · 2014-06-06T07:37:50Z

Merged build triggered.

AmplabJenkins · 2014-06-06T09:09:52Z

Build started.

AmplabJenkins · 2014-06-06T10:24:34Z

Build finished. All automated tests passed.

AmplabJenkins · 2014-06-06T10:24:34Z

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15503/

AmplabJenkins · 2014-06-06T10:24:36Z

Merged build started.

AmplabJenkins · 2014-06-06T11:39:19Z

Merged build finished. All automated tests passed.

AmplabJenkins · 2014-06-06T11:39:19Z

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15505/

pwendell · 2014-06-06T18:38:57Z

Okay great - those are good reasons, I just wanted to have some documentation somewhere of the motivation for this change. I can merge this, thanks.

Author: witgo <witgo@qq.com> Closesapache#713 from witgo/scalatest and squashes the following commits: b627a6a [witgo] merge master 51fb3d6 [witgo] merge master 3771474 [witgo] fix RDDSuite 996d6f9 [witgo] fix TimeStampedWeakValueHashMap test 9dfa4e7 [witgo] merge bug 1479b22 [witgo] merge master 29b9194 [witgo] fix code style 022a7a2 [witgo] fix test dependency a52c0fa [witgo] fix test dependency cd8f59d [witgo] Merge branch 'master' of https://github.com/apache/spark into scalatest 046540d [witgo] fix RDDSuite.scala 2c543b9 [witgo] fix ReplSuite.scala c458928 [witgo] update scalatest to version 2.1.5 Conflicts: core/pom.xml core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala core/src/test/scala/org/apache/spark/util/TimeStampedHashMapSuite.scala pom.xml project/SparkBuild.scala sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetQuerySuite.scala

Author: witgo <witgo@qq.com> Closesapache#713 from witgo/scalatest and squashes the following commits: b627a6a [witgo] merge master 51fb3d6 [witgo] merge master 3771474 [witgo] fix RDDSuite 996d6f9 [witgo] fix TimeStampedWeakValueHashMap test 9dfa4e7 [witgo] merge bug 1479b22 [witgo] merge master 29b9194 [witgo] fix code style 022a7a2 [witgo] fix test dependency a52c0fa [witgo] fix test dependency cd8f59d [witgo] Merge branch 'master' of https://github.com/apache/spark into scalatest 046540d [witgo] fix RDDSuite.scala 2c543b9 [witgo] fix ReplSuite.scala c458928 [witgo] update scalatest to version 2.1.5

* wip * API with docs * move from Executor constructor to runtime * style * license * style * address comments

…erformace issue (apache#712) (apache#713)

witgo added 3 commits May 9, 2014 11:16

update scalatest to version 2.1.5
c458928

fix ReplSuite.scala
2c543b9

fix RDDSuite.scala
046540d

witgo added 3 commits May 9, 2014 17:50

Merge branch 'master' ofhttps://github.com/apache/sparkinto scalatest
cd8f59d

fix test dependency
a52c0fa

fix test dependency
022a7a2

witgo changed the title ~~[WIP] update scalatest to version 2.1.5~~[WIP] [SPARK-1841]: update scalatest to version 2.1.5May 15, 2014

witgo mentioned this pull request May 16, 2014
Remove compile-scoped junit dependency. #794
Closed

witgo added 2 commits May 16, 2014 13:15

fix code style
29b9194

merge master
1479b22

witgo added 3 commits May 16, 2014 14:00

merge bug
9dfa4e7

fix TimeStampedWeakValueHashMap test
996d6f9

fix RDDSuite
3771474

witgo changed the title ~~[WIP] [SPARK-1841]: update scalatest to version 2.1.5~~ [SPARK-1841]: update scalatest to version 2.1.5May 23, 2014

merge master
51fb3d6

merge master
b627a6a

asfgit closed this in 41c4a33Jun 6, 2014

witgo deleted the scalatest branch June 7, 2014 01:08

witgo mentioned this pull request Jun 25, 2014
Resolve sbt warnings during build Ⅱ #1153
Closed

Alexis-D pushed a commit to Alexis-D/spark that referenced this pull request Nov 16, 2020
Add ExecutorPlugin methods called on Task Start/End (apache#713)
73ce892
* wip * API with docs * move from Executor constructor to runtime * style * license * style * address comments

RolatZhang pushed a commit to RolatZhang/spark that referenced this pull request Dec 8, 2023
AL-9236 Replace guava ordering with guava32 code snippet to resolve p…
d65de74
…erformace issue (apache#712) (apache#713)

RolatZhang pushed a commit to RolatZhang/spark that referenced this pull request Dec 11, 2023
AL-9236 Replace guava ordering with guava32 code snippet to resolve p…
faf3d33
…erformace issue (apache#712) (apache#713)

Uh oh!

Conversation

witgo commented May 9, 2014

Uh oh!

AmplabJenkins commented May 9, 2014

Uh oh!

pwendell commented May 16, 2014

Uh oh!

AmplabJenkins commented May 16, 2014

Uh oh!

AmplabJenkins commented May 16, 2014

Uh oh!

AmplabJenkins commented May 16, 2014

Uh oh!

AmplabJenkins commented May 16, 2014

Uh oh!

witgo commented May 16, 2014

Uh oh!

ktham commented Jun 4, 2014

Uh oh!

pwendell commented Jun 4, 2014

Uh oh!

ktham commented Jun 4, 2014

Uh oh!

rxin commented Jun 6, 2014

Uh oh!

AmplabJenkins commented Jun 6, 2014

Uh oh!

AmplabJenkins commented Jun 6, 2014

Uh oh!

AmplabJenkins commented Jun 6, 2014

Uh oh!

AmplabJenkins commented Jun 6, 2014

Uh oh!

AmplabJenkins commented Jun 6, 2014

Uh oh!

AmplabJenkins commented Jun 6, 2014

Uh oh!

AmplabJenkins commented Jun 6, 2014

Uh oh!

AmplabJenkins commented Jun 6, 2014

Uh oh!

pwendell commented Jun 6, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants