Uh oh!
There was an error while loading. Please reload this page.
[SPARK-1820][tools] Make GenerateMimaIgnore @DeveloperApi annotation aware. - #845
[SPARK-1820][tools] Make GenerateMimaIgnore @DeveloperApi annotation aware.#845nikhils05 wants to merge 6 commits into
Conversation
AmplabJenkins
commented
May 21, 2014
Can one of the admins verify this patch? |
pwendell
commented
May 25, 2014
Jenkins, test this please. |
AmplabJenkins
commented
May 25, 2014
Merged build triggered. |
AmplabJenkins
commented
May 25, 2014
Merged build started. |
AmplabJenkins
commented
May 25, 2014
Merged build finished. |
AmplabJenkins
commented
May 25, 2014
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15189/ |
There was a problem hiding this comment.
Please convert tabs to spaces (otherwise indentation looks really wack on github).
There was a problem hiding this comment.
It might be better to call this something like val developerApi to make it grammatically consistent with the other variables. I.e.
if (directlyPrivateSpark || indirectlyPrivateSpark || developerApi) privateClasses += className
pwendell
commented
May 26, 2014
I added some style feedback. This is failing several style tests: |
nikhils05
commented
May 26, 2014
I've made the suggested changes... |
pwendell
commented
May 27, 2014
Jenkins, test this please. |
AmplabJenkins
commented
May 27, 2014
Merged build triggered. |
AmplabJenkins
commented
May 27, 2014
Merged build started. |
AmplabJenkins
commented
May 27, 2014
Merged build finished. |
AmplabJenkins
commented
May 27, 2014
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15214/ |
pwendell
commented
May 28, 2014
Jenkins, test this please. Jenkins, this is okay to test. |
AmplabJenkins
commented
May 28, 2014
Merged build triggered. |
AmplabJenkins
commented
May 28, 2014
Merged build started. |
AmplabJenkins
commented
May 28, 2014
Merged build finished. |
AmplabJenkins
commented
May 28, 2014
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15247/ |
ScrapCodes
commented
May 28, 2014
#904 Fixes the build and few other style things. |
AmplabJenkins
commented
Jun 27, 2014
Can one of the admins verify this patch? |
ScrapCodes
commented
Sep 2, 2014
@nikhils05 Can you close this PR ? |
pwendell
commented
Sep 2, 2014
Yeah let's close this issue for now. |
… MAPRSASL (apache#845) Co-authored-by: Egor Krivokon <>
… MAPRSASL (apache#845) Co-authored-by: Egor Krivokon <>
… MAPRSASL (apache#845) Co-authored-by: Egor Krivokon <>
Solution for : Add all the classes with DeveloperApi annotation in Mima excludes.