Skip to content

[SPARK-10477][SQL] using DSL in ColumnPruningSuite to improve readability - #8645

Closed
cloud-fan wants to merge 1 commit into
apache:masterfrom
cloud-fan:test
Closed

[SPARK-10477][SQL] using DSL in ColumnPruningSuite to improve readability#8645
cloud-fan wants to merge 1 commit into
apache:masterfrom
cloud-fan:test

Conversation

@cloud-fan

@cloud-fancloud-fan commented Sep 7, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@SparkQA

SparkQA commented Sep 7, 2015

Copy link
Copy Markdown

Test build #42102 has finished for PR 8645 at commit 861cf94.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fancloud-fan changed the title [SPARK-10477][SQL] using DSL in ColumnPruningSuite to improve readablity[SPARK-10477][SQL] using DSL in ColumnPruningSuite to improve readabilitySep 8, 2015
@JoshRosen

JoshRosen commented Oct 16, 2015

Copy link
Copy Markdown
Contributor

Jenkins, retest this please

@JoshRosen

JoshRosen commented Oct 17, 2015

Copy link
Copy Markdown
Contributor

Jenkins, retest this please.

@SparkQA

SparkQA commented Oct 18, 2015

Copy link
Copy Markdown

Test build #43889 has finished for PR 8645 at commit 861cf94.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14

andrewor14 commented Dec 15, 2015

Copy link
Copy Markdown
Contributor

This seems like a low hanging fruit to merge. @davies@yhuai can you have a look?

@andrewor14

andrewor14 commented Dec 15, 2015

Copy link
Copy Markdown
Contributor

retest this please

@SparkQA

SparkQA commented Dec 15, 2015

Copy link
Copy Markdown

Test build #47744 has finished for PR 8645 at commit 861cf94.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai

yhuai commented Dec 15, 2015

Copy link
Copy Markdown
Contributor

Looks fine to merge.

@cloud-fan Was there any issue with the original code?

@cloud-fan

cloud-fan commented Dec 16, 2015

Copy link
Copy Markdown
ContributorAuthor

No, just to make it more readable.

@andrewor14

andrewor14 commented Dec 16, 2015

Copy link
Copy Markdown
Contributor

OK, merging into master 1.6 thanks

asfgit pushed a commit that referenced this pull request Dec 16, 2015
@cloud-fanAndrew Or
[SPARK-10477][SQL] using DSL in ColumnPruningSuite to improve readabi…
fb08f7b
…lity
Author: Wenchen Fan <cloud0fan@outlook.com>
Closes#8645 from cloud-fan/test.
(cherry picked from commit a89e8b6)
Signed-off-by: Andrew Or <andrew@databricks.com>
@cloud-fan
cloud-fan deleted the test branch December 16, 2015 02:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cloud-fan@SparkQA@JoshRosen@andrewor14@yhuai