Uh oh!
There was an error while loading. Please reload this page.
[SPARK-10849][SQL] Adding field metadata property to override default jdbc data source type mapping. - #9352
Conversation
marmbrus
commented
Oct 29, 2015
ok to test |
SparkQA
commented
Oct 29, 2015
Test build #44586 has finished for PR 9352 at commit
|
sureshthalamati
commented
Oct 29, 2015
Failed test is test_trainOn_predictOn (main.StreamingKMeansTest). It seems to be unrelated to my changes. Can we retest this please. |
sureshthalamati
commented
Oct 30, 2015
Thinking about this more , I realized current version of the patch may introduce SQL injection. I will update the pull request with a new version of the fix. |
sureshthalamati
commented
Oct 30, 2015
SparkQA
commented
Oct 30, 2015
Test build #44699 has finished for PR 9352 at commit
|
sureshthalamati
commented
Oct 31, 2015
retest this please. Test failure is unrelated to my changes. Failed test is org.apache.spark.sql.sources.JsonHadoopFsRelationSuite.test all data types - TimestampType. It passes in my environment. |
rick-ibm
commented
Nov 4, 2015
Thanks for addressing the SQL injection concerns, Suresh. LGTM. |
sureshthalamati
commented
Nov 16, 2015
Jenkins, retest this please. |
tristanreid
commented
Jan 18, 2016
Anyone know the status of this change? Is there anything blocking, or was it superceded by something else? Thanks... |
AmplabJenkins
commented
Apr 29, 2016
Can one of the admins verify this patch? |
This patch allows users to override default type mapping of data frame field to database column type when writing data frame to jdbc data sources.
In some cases user may want to use specific database data type mapping for fields based on the database configuration (page size , type of table spaces ..etc) instead of the defaults. For example large varchar size for all the columns may not fit in row size limits , user may want to use mix of varchar , and clob types. Max precision supported in some database systems might be less than the spark decimal precision, in such cases user can use this option to adjust the decimal type precision , and scale to match the target database.
Added a new field meta data property name db.column.type . I am not sure what is the convention for these type of property names. Please let me know it it needs to be changed.
@rxin@marmbrus