Uh oh!
There was an error while loading. Please reload this page.
[SPARK-11468][SPARKR] add stddev/variance agg functions for Column - #9489
[SPARK-11468][SPARKR] add stddev/variance agg functions for Column#9489felixcheung wants to merge 8 commits into
Conversation
SparkQA
commented
Nov 5, 2015
Test build #45109 has finished for PR 9489 at commit
|
SparkQA
commented
Nov 5, 2015
Test build #45148 has finished for PR 9489 at commit
|
shivaram
commented
Nov 9, 2015
cc @sun-rui |
davies
commented
Nov 9, 2015
LGTM |
mengxr
commented
Nov 9, 2015
Should we add aliases |
felixcheung
commented
Nov 10, 2015
shivaram
commented
Nov 10, 2015
Looks like dply has aggregate functions for variance, standard deviations ? Can we just match the syntax there ? https://www.rstudio.com/wp-content/uploads/2015/02/data-wrangling-cheatsheet.pdf |
felixcheung
commented
Nov 10, 2015
This does work Also these work I think they match dplyr, so I could name them |
sun-rui
commented
Nov 10, 2015
@shivaram, I looked at dplyr package, there is no "sd", "var" defined in the package, seems the page is referencing "sd" "var" in R base. Yes, stddev/variance agg functions we are adding have similar semantic as "sd" and "var" in R, as you can think of a Column as a vector of same type. So we'd better add aliases for them. Note that var() in R computes sample variance (I think "sd" also uses sample variance, but not verified) instead of population variance. |
There was a problem hiding this comment.
"stddev_pop" before "stddev_samp",
shivaram
commented
Nov 10, 2015
Yeah in that case lets add aliases for @felixcheung I think similar functions like |
SparkQA
commented
Nov 11, 2015
Test build #45581 has finished for PR 9489 at commit
|
SparkQA
commented
Nov 11, 2015
Test build #45585 has finished for PR 9489 at commit
|
sun-rui
commented
Nov 11, 2015
LGTM |
davies
commented
Nov 11, 2015
Merging this into master and 1.6 branch, thanks! |
Checked names, none of them should conflict with anything in base
@shivaram@davies@rxin