Uh oh!
There was an error while loading. Please reload this page.
[SPARK-11482][SQL] Make maven repo for Hive metastore jars configurable - #9543
[SPARK-11482][SQL] Make maven repo for Hive metastore jars configurable#9543xguo27 wants to merge 2 commits into
Conversation
WangTaoTheTonic
commented
Nov 9, 2015
I think it can be used for who have their custom hive hosted on their own maven repository. Though using maven to download hive metastore jars is using for test, I still think this is a nice feature. |
xguo27
commented
Nov 9, 2015
Thanks WangTao for your comment! Based on the comment on my other PR for Spark-11562, I will also add documentation for this. |
xguo27
commented
Nov 20, 2015
rxin
commented
Nov 20, 2015
I think this is fine to add. |
rxin
commented
Nov 20, 2015
Jenkins, test this please. |
xguo27
commented
Nov 21, 2015
@rxin Thanks, Reynold! Somehow no test was triggered. Not sure why. |
SparkQA
commented
Nov 21, 2015
Test build #2095 has finished for PR 9543 at commit
|
xguo27
commented
Nov 22, 2015
@rxin Sorry about the failure, can we re-test please? |
SparkQA
commented
Nov 24, 2015
Test build #2100 has finished for PR 9543 at commit
|
There was a problem hiding this comment.
either put each on one line, or don't wrap them at all here.
[SPARK-11482][SQL] documentation for configurable maven repo Fix Scalastyle check failure Correct code format
xguo27
commented
Nov 28, 2015
There was a problem hiding this comment.
Can you use HIVE_METASTORE_MAVEN_REPO's default value at here? So, in case we update that default value, this one will be updated as well.
yhuai
commented
Nov 29, 2015
@xguo27 Can I ask what is your specific use case for this? |
xguo27
commented
Nov 29, 2015
Thanks @yhuai for reviewing my code! I have updated per your suggestion. To answer your question, I personally do not have a use case for this. My take on the JIRA reporter's use case is that user might host their own customized/modified Hive jars on their maven site which might provide specific functionality. |
AmplabJenkins
commented
May 12, 2016
Can one of the admins verify this patch? |
rxin
commented
Dec 7, 2016
I'm going to close this one for now. |
Closesapache#14537. Closesapache#16181. Closesapache#8318. Closesapache#6848. Closesapache#7265. Closesapache#9543.
Introducing a property called "spark.sql.hive.maven.repo" to let user configure the maven repository to download Hive Metastore jars.