Uh oh!
There was an error while loading. Please reload this page.
[SPARK-11631][Scheduler] Adding 'Starting DAGScheduler' log - #9603
[SPARK-11631][Scheduler] Adding 'Starting DAGScheduler' log#9603xguo27 wants to merge 2 commits into
Conversation
AmplabJenkins
commented
Nov 10, 2015
Can one of the admins verify this patch? |
There was a problem hiding this comment.
I'd rather move it to DAGScheduler's constructor as that's where the message belongs.
andrewor14
commented
Nov 12, 2015
Meh, I don't really think this is worth doing. It doesn't add any value or fix anything. |
xguo27
commented
Nov 17, 2015
I agree it is trivial, just thought I could quickly add a log statement. If Jacek agrees, I can close those PR. |
jaceklaskowski
commented
Nov 17, 2015
I don't agree with @andrewor14. It does add a value of being consistent with how Spark informs about its status - if it says "Stopping..." at INFO it should be corresponding "Starting..." at INFO. That was my initial goal. Consistency is the goal and the value here. Why does Spark report about services being stopped at all? What's the rationale? I would change it to DEBUG, but since all the other logs about starting services are at INFO, I'd leave it as is until someone reports it should be done. |
xguo27
commented
Nov 23, 2015
@andrewor14 What is your take on Jacek's comment? I don't think it's a bad idea to make it more consistent with a matching log message. Please let me know. Thx! |
andrewor14
commented
Nov 23, 2015
I just don't see any value. It's obvious that the scheduler is starting / stopping. Not a big deal if we merge it, but I just can't imagine anyone finding this message useful. |
markhamstra
commented
Nov 23, 2015
Beyond that, the message is actually somewhat misleading. The "Stopping" message occurs in |
rxin
commented
Nov 24, 2015
I think this message is complete useless. I'd just remove it rather than spending time bickering about the wording. |
xguo27
commented
Nov 24, 2015
OK, I will close it. Thanks! |
No description provided.