Skip to content

[SPARK-11706][Streaming]Fix the bug that Streaming Python tests cannot report failures - #9669

Closed
zsxwing wants to merge 6 commits into
apache:masterfrom
zsxwing:streaming-python-tests
Closed

[SPARK-11706][Streaming]Fix the bug that Streaming Python tests cannot report failures#9669
zsxwing wants to merge 6 commits into
apache:masterfrom
zsxwing:streaming-python-tests

Conversation

@zsxwing

@zsxwingzsxwing commented Nov 12, 2015

Copy link
Copy Markdown
Member

This PR just checks the test results and returns 1 if the test fails, so that run-tests.py can mark it fail.

@zsxwingzsxwing mentioned this pull request Nov 12, 2015
Closed
@zsxwing

zsxwing commented Nov 12, 2015

Copy link
Copy Markdown
MemberAuthor

Manually tested this patch locally by adding 1 / 0 to test_map. It did report the failure after applying this patch.

zsxwing
zsxwing reviewed Nov 12, 2015
View reviewed changes
Comment threadpython/pyspark/streaming/tests.py

@zsxwingzsxwingNov 12, 2015

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unittest.main will call sys.exit after finishing tests, so we should not use it here.

@SparkQA

SparkQA commented Nov 12, 2015

Copy link
Copy Markdown

Test build #45753 has finished for PR 9669 at commit bbfea87.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

SparkQA commented Nov 12, 2015

Copy link
Copy Markdown

Test build #45759 has finished for PR 9669 at commit 1f3764b.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gliptakgliptak mentioned this pull request Nov 12, 2015
Closed
@zsxwing

zsxwing commented Nov 12, 2015

Copy link
Copy Markdown
MemberAuthor

No surprises. Exposed a lot of test failures. Fixing them

@SparkQA

SparkQA commented Nov 12, 2015

Copy link
Copy Markdown

Test build #45776 has finished for PR 9669 at commit 08d0f60.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

tdas
tdas reviewed Nov 12, 2015
View reviewed changes
Comment threadpython/pyspark/streaming/tests.py

@tdastdasNov 12, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

@zsxwingzsxwingNov 12, 2015

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StreamingContext doesn't have a static _jvm. It's an instance field.

@SparkQA

SparkQA commented Nov 12, 2015

Copy link
Copy Markdown

Test build #45784 has finished for PR 9669 at commit a5699e0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@tdas

tdas commented Nov 13, 2015

Copy link
Copy Markdown
Contributor

Merging this to master, 1.6 and 1.5. Thanks @zsxwing for catching this.

asfgit pushed a commit that referenced this pull request Nov 13, 2015
@zsxwing@tdas
[SPARK-11706][STREAMING] Fix the bug that Streaming Python tests cann…
c3da2bd
…ot report failures
This PR just checks the test results and returns 1 if the test fails, so that `run-tests.py` can mark it fail.
Author: Shixiong Zhu <shixiong@databricks.com>
Closes#9669 from zsxwing/streaming-python-tests.
(cherry picked from commit ec80c0c)
Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
dskrvk pushed a commit to dskrvk/spark that referenced this pull request Nov 13, 2015
@zsxwing@dskrvk
[SPARK-11706][STREAMING] Fix the bug that Streaming Python tests cann…
afe814b
…ot report failures
This PR just checks the test results and returns 1 if the test fails, so that `run-tests.py` can mark it fail.
Author: Shixiong Zhu <shixiong@databricks.com>
Closesapache#9669 from zsxwing/streaming-python-tests.
@zsxwingzsxwing mentioned this pull request Nov 13, 2015
Closed
@zsxwing
zsxwing deleted the streaming-python-tests branch November 13, 2015 17:52
@zsxwingzsxwing mentioned this pull request Nov 30, 2015
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zsxwing@SparkQA@tdas