[SPARK-11724] [SQL] Change casting between int and timestamp to consistently treat int in seconds.

[nongli]

Hive has since changed this behavior as well. https://issues.apache.org/jira/browse/HIVE-3454

[cloud-fan]

Good catch! The currently behaviour looks wierd to me, how does hive handle this? cc @yhuai

[SparkQA]

Test build #45842 has finished for PR 9685 at commit 9aa668c.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):\n * case class StddevSamp(child: Expression,\n * case class StddevPop(\n * class TypedColumn[-T, U](\n

[nongli]

Good catch! The currently behaviour looks wierd to me, how does hive handle this? cc @yhuai

It looks like Hive fixed this in 1.2. https://issues.apache.org/jira/browse/HIVE-3454

[yhuai]

Seems we need to update those golden files. I believe we can set HIVE_HOME to hive 1.2.1's dir and delete those golden files. Then, when we run those tests again, we will first let Hive generate results.

[yhuai]

Seems Hive is still wrong when the data type is int. See

hive> SELECT CAST(CAST(-1200 AS TIMESTAMP) AS INT);
OK
-2
Time taken: 0.047 seconds, Fetched: 1 row(s)
hive> SELECT CAST(CAST(-1200.0 AS TIMESTAMP) AS INT);
OK
-1200
Time taken: 0.046 seconds, Fetched: 1 row(s)

Let's delete those golden files and create our own test (using test(...) {...} instead of using createQueryTest(..., ...)).

[SparkQA]

Test build #46364 has finished for PR 9685 at commit c4f2da1.

• This patch fails from timeout after a configured wait of 250m.
• This patch merges cleanly.
• This patch adds no public classes.

[yhuai]

test this please

[SparkQA]

Test build #46391 has finished for PR 9685 at commit c4f2da1.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[yhuai]

Seems we do not include the new golden file? I can generate it tomorrow.

[SparkQA]

Test build #46435 has finished for PR 9685 at commit 347de98.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[yhuai]

LGTM. Thank you for the fix! Merging it to master and branch 1.6.