Uh oh!
There was an error while loading. Please reload this page.
[SPARK-11731][STREAMING] Enable batching on Driver WriteAheadLog by default - #9695
Closed
brkyvz wants to merge 3 commits into
Closed
[SPARK-11731][STREAMING] Enable batching on Driver WriteAheadLog by default#9695brkyvz wants to merge 3 commits into
brkyvz wants to merge 3 commits into
Conversation
SparkQA
commented
Nov 13, 2015
Test build #45872 has finished for PR 9695 at commit
|
SparkQA
commented
Nov 13, 2015
Test build #45876 has finished for PR 9695 at commit
|
brkyvz
commented
Nov 13, 2015
ContributorAuthor
retest this please |
SparkQA
commented
Nov 13, 2015
Test build #45884 has finished for PR 9695 at commit
|
zsxwing
commented
Nov 13, 2015
Member
LGTM |
harishreedharan
commented
Nov 13, 2015
Contributor
+1 |
tdas
commented
Nov 16, 2015
Contributor
LGTM. Merging this to master and 1.6 |
asfgit pushed a commit
that referenced
this pull request
Nov 16, 2015
…efault Using batching on the driver for the WriteAheadLog should be an improvement for all environments and use cases. Users will be able to scale to much higher number of receivers with the BatchedWriteAheadLog. Therefore we should turn it on by default, and QA it in the QA period. I've also added some tests to make sure the default configurations are correct regarding recent additions: - batching on by default - closeFileAfterWrite off by default - parallelRecovery off by default Author: Burak Yavuz <brkyvz@gmail.com> Closes#9695 from brkyvz/enable-batch-wal. (cherry picked from commit de5e531) Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using batching on the driver for the WriteAheadLog should be an improvement for all environments and use cases. Users will be able to scale to much higher number of receivers with the BatchedWriteAheadLog. Therefore we should turn it on by default, and QA it in the QA period.
I've also added some tests to make sure the default configurations are correct regarding recent additions: