Uh oh!
There was an error while loading. Please reload this page.
[SPARK-11738] [SQL] Making ArrayType orderable - #9718
Closed
yhuai wants to merge 6 commits into
Closed
Conversation
ContributorAuthor
There was a problem hiding this comment.
These lines have been moved to compareValue.
yhuai
commented
Nov 15, 2015
ContributorAuthor
@davies take a look? |
SparkQA
commented
Nov 15, 2015
Test build #45940 has finished for PR 9718 at commit
|
SparkQA
commented
Nov 15, 2015
Test build #45945 has finished for PR 9718 at commit
|
SparkQA
commented
Nov 15, 2015
Test build #45946 has finished for PR 9718 at commit
|
Contributor
There was a problem hiding this comment.
These could be defined in the loop (let compiler to optimize them easily)
davies
commented
Nov 15, 2015
Contributor
LGTM, and some minor comments |
SparkQA
commented
Nov 15, 2015
Test build #45955 has finished for PR 9718 at commit
|
davies
commented
Nov 15, 2015
Contributor
Merged into master and 1.6 branch, thanks! |
asfgit pushed a commit
that referenced
this pull request
Nov 15, 2015
https://issues.apache.org/jira/browse/SPARK-11738 Author: Yin Huai <yhuai@databricks.com> Closes#9718 from yhuai/makingArrayOrderable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SPARK-11738