Skip to content

[SPARK-11762] [network] Account for active streams when couting outstanding requests. - #9747

Closed
vanzin wants to merge 1 commit into
apache:masterfrom
vanzin:SPARK-11762
Closed

[SPARK-11762] [network] Account for active streams when couting outstanding requests.#9747
vanzin wants to merge 1 commit into
apache:masterfrom
vanzin:SPARK-11762

Conversation

@vanzin

Copy link
Copy Markdown
Contributor

This way the timeout handling code can correctly close "hung" channels that are
processing streams.

…anding requests.
This way the timeout handling code can correctly close "hung" channels that are
processing streams.
@SparkQA

Copy link
Copy Markdown

Test build #46027 has finished for PR 9747 at commit 4df514c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class StreamingListener(object):\n

@vanzin

Copy link
Copy Markdown
ContributorAuthor

/cc @rxin@zsxwing

@zsxwing

Copy link
Copy Markdown
Member

LGTM.

BTW, StreamInterceptor should catch exception from callback.onComplete, onData, onFailure. Otherwise, it may screw up the stream.

@zsxwing

Copy link
Copy Markdown
Member

BTW, StreamInterceptor should catch exception from callback.onComplete, onData, onFailure. Otherwise, it may screw up the stream.

@vanzin could you fix this in a separate PR?

@vanzin

Copy link
Copy Markdown
ContributorAuthor

BTW, StreamInterceptor should catch exception from callback.onComplete, onData, onFailure.

@vanzinvanzin closed this Nov 20, 2015
@vanzinvanzin reopened this Nov 20, 2015
@vanzin

Copy link
Copy Markdown
ContributorAuthor

Oops. Hit the wrong thing.

@vanzin

Copy link
Copy Markdown
ContributorAuthor

BTW, StreamInterceptor should catch exception from callback.onComplete, onData, onFailure. Otherwise, it may screw up the stream.

It's not as simple as catching the exceptions. StreamInterceptor would have to switch to a mode where it ignores all future data until the stream is over, if the channel is to be kept open.

Right now an exception will bubble up and end up handled by TransportChannelHandler, which will close the channel.

@zsxwing

Copy link
Copy Markdown
Member

Right now an exception will bubble up and end up handled by TransportChannelHandler, which will close the channel.

Sounds acceptable since #9530 uses a separate channel to stream files.

@vanzin

Copy link
Copy Markdown
ContributorAuthor

Merging to master.

@vanzin
vanzin deleted the SPARK-11762 branch November 23, 2015 19:41
asfgit pushed a commit that referenced this pull request Nov 25, 2015
…nding requests.
This way the timeout handling code can correctly close "hung" channels that are
processing streams.
Author: Marcelo Vanzin <vanzin@cloudera.com>
Closes#9747 from vanzin/SPARK-11762.
(cherry picked from commit 5231cd5)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vanzin@SparkQA@zsxwing