Uh oh!
There was an error while loading. Please reload this page.
[SPARK-11835] Adds a sidebar menu to MLlib's documentation - #9826
[SPARK-11835] Adds a sidebar menu to MLlib's documentation#9826thunterdb wants to merge 6 commits into
Conversation
SparkQA
commented
Nov 19, 2015
Test build #46280 has finished for PR 9826 at commit
|
mengxr
commented
Nov 19, 2015
thunterdb
commented
Nov 19, 2015
@mengxr with the fixes, the top menu breaks before the side menu :-) |
thunterdb
commented
Nov 19, 2015
This is about as much as I can do with my very limited knowledge of CSS, so additional fixes can be done in a separate PR. |
SparkQA
commented
Nov 19, 2015
Test build #46343 has finished for PR 9826 at commit
|
andrewor14
commented
Nov 19, 2015
nice! I wonder if there's something more general we can do. This is useful across all pages in the docs so it would be worth investigating if there are existing frameworks we can use. E.g. this format is nice: http://docs.scala-lang.org/overviews/core/futures.html |
thunterdb
commented
Nov 19, 2015
@andrewor14 this is a different issue: the SIPs show the table of contents within one document, which we already have with the |
thunterdb
commented
Nov 19, 2015
@mengxr based on our discussions, here is a slightly updated version:
|
mengxr
commented
Nov 20, 2015
@thunterdb Could you try the following CSS: .left-menu-wrapper {
position: absolute;
height:100%;
width:256px;
margin-top:-20px;
padding-top:20px;
background-color:#F0F8FC;
}
.left-menu {
position: fixed;
width:256px;
padding-right:10px;
}It doesn't fix the issue with hiding the sidebar but makes the background lighter: |
thunterdb
commented
Nov 20, 2015
@mengxr comment addressed |
mengxr
commented
Nov 20, 2015
test this please |
2 similar comments
mengxr
commented
Nov 20, 2015
test this please |
mengxr
commented
Nov 21, 2015
test this please |
SparkQA
commented
Nov 21, 2015
Test build #46457 has finished for PR 9826 at commit
|
This PR adds a sidebar menu when browsing the user guide of MLlib. It uses a YAML file to describe the structure of the documentation. It should be trivial to adapt this to the other projects.  Author: Timothy Hunter <timhunter@databricks.com> Closes#9826 from thunterdb/spark-11835. (cherry picked from commit fc4b792) Signed-off-by: Xiangrui Meng <meng@databricks.com>
mengxr
commented
Nov 23, 2015
LGTM. Merged into master and branch-1.6. Thanks! (The Jenkins test failure is irrelevant. The PR build doesn't compile doc anyway. So I verified the changes on my local computer.) |





This PR adds a sidebar menu when browsing the user guide of MLlib. It uses a YAML file to describe the structure of the documentation. It should be trivial to adapt this to the other projects.