Uh oh!
There was an error while loading. Please reload this page.
[SPARK-11520][ML] RegressionMetrics should support instance weights - #9907
Closed
Lewuathe wants to merge 1 commit into
Closed
[SPARK-11520][ML] RegressionMetrics should support instance weights#9907Lewuathe wants to merge 1 commit into
Lewuathe wants to merge 1 commit into
Conversation
SparkQA
commented
Nov 23, 2015
Test build #46525 has finished for PR 9907 at commit
|
Lewuathe
commented
Nov 25, 2015
ContributorAuthor
@mengxr@jkbradley Could you review this? Thanks. |
Contributor
There was a problem hiding this comment.
We should rename this summary variable, it is used 3 times for different objects.
Also, sample is a bit too generic here, and using the _xx methods are not very intuitive. I suggest you unpack the tuple fully: { case (currentSummary, (vec, weight)) => currentSummary.add(vec, weight) }
thunterdb
commented
Jan 6, 2016
Contributor
@Lewuathe thanks for your patch. I think it will require more work in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be important to improve LinearRegressionSummary, which currently has a mix of weighted and unweighted metrics.