Uh oh!
There was an error while loading. Please reload this page.
build: use GitHub Actions concurrency groups to cancel workflows - #25243
Closed
sebastianliebscher wants to merge 2 commits into
Closed
build: use GitHub Actions concurrency groups to cancel workflows#25243sebastianliebscher wants to merge 2 commits into
sebastianliebscher wants to merge 2 commits into
Conversation
villebro
commented
Sep 9, 2023
Member
@sebastianliebscher nice work, looking forward to reviewing this once it's out of draft state! |
sebastianliebscher
marked this pull request as ready for review
September 10, 2023 07:33
sebastianliebscher
requested review from
betodealmeida, craig-rueda, eschutho, geido, john-bodley, kgabryje, mistercrunch, nytai, rusackas and villebro
as code ownersSeptember 10, 2023 07:33
sebastianliebscher
commented
Oct 6, 2023
ContributorAuthor
ping @villebro |
rusackas
commented
Jan 28, 2024
Member
This one seems to have slipped under the radar, but it's a fantastic idea! It just needs a rebase, and I think we should be all good. CC @mistercrunch since he might want to take a look at this too. |
mistercrunch
commented
Jan 31, 2024
Member
LGTM, let's rebase and merge it! |
rusackas
approved these changes
Jan 31, 2024
mistercrunch added a commit
that referenced
this pull request
Feb 1, 2024
Taking over #25243, where @sebastianliebscher did great work and submitted this idea. I'm re-opening under a new PR to accelerate things a bit. I've been triggering lots and lots of CI jobs while working on docker and feeling guilty about my carbon footprint. Here I grepped for workflows that have pull_request events and copy pasted the exact same snippet everywhere except for one place and that's the comment-triggered ephemeral builds, where I reference the issue number instead of the PR number. This should allow for someone to oops and retrigger the ephemeral build, and the lastest one should always land first, fixing potential race conditions
mistercrunch
commented
Feb 1, 2024
Member
Thank @sebastianliebscher for the idea/code, took over here -> #26945 closing this one |
DevNoctis1001 added a commit
to DevNoctis1001/Superset-data_visualization
that referenced
this pull request
Feb 11, 2024
Taking over apache/superset#25243, where @sebastianliebscher did great work and submitted this idea. I'm re-opening under a new PR to accelerate things a bit. I've been triggering lots and lots of CI jobs while working on docker and feeling guilty about my carbon footprint. Here I grepped for workflows that have pull_request events and copy pasted the exact same snippet everywhere except for one place and that's the comment-triggered ephemeral builds, where I reference the issue number instead of the PR number. This should allow for someone to oops and retrigger the ephemeral build, and the lastest one should always land first, fixing potential race conditions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR removes custom scripts to cancel running GitHub Actions workflows and replaces them with the built-in functionality concurrency groups.
This will cancel all running workflow jobs for PRs only. In case it is not a PR, this won't cancel running jobs as
run_idis unique.Partially reverts #12090
In case we want to cancel running jobs for commits to master or release tags also, it can be modified to:
https://docs.github.com/en/actions/learn-github-actions/contexts#github-context
TESTING INSTRUCTIONS
You can see the cancelled workflows for the first commit:

ADDITIONAL INFORMATION