Uh oh!
There was an error while loading. Please reload this page.
TAJO-1952: Implement PartitionFileFragment - #846
Conversation
There was a problem hiding this comment.
I'm going to give a suggestion. We need to keep each method for one purpose if possible. That approach would keep logic simpler.
hyunsik
commented
Nov 19, 2015
Could you rebase it against the latest revision? I'd like to try the patch on my machine. |
blrunner
commented
Nov 19, 2015
Thank you for your review. I've just rebased it against the latest version. |
There was a problem hiding this comment.
In my opionion, partitionKeys would be more proper because the attribute includes concatenated partition keys.
blrunner
commented
Nov 20, 2015
Thank your for your review. I've just reflected your comments. |
blrunner
commented
Nov 23, 2015
I updated the patch as following:
For the reference, I've tried to maintain existing codes as far as possible. |
blrunner
commented
Nov 24, 2015
Updated the patch as following:
|
blrunner
commented
Nov 25, 2015
Added unit test cases for PartitionedTableRewriter |
blrunner
commented
Dec 3, 2015
Thank you for your detailed review. I reflected your comments. |
blrunner
commented
Dec 7, 2015
I changed |
blrunner
commented
Dec 10, 2015
Evaluated patch testing before and after
The results were same as following:
|
blrunner
commented
Jan 5, 2016
The Travis CI Build seems like a fail by another reason. Here is the pre-commit report by lasted patch as follows. https://builds.apache.org/job/PreCommit-TAJO-Build/900//console |
blrunner
commented
Jan 17, 2016
Is there a problem that needs to be fixed? |
blrunner
commented
Mar 21, 2016
I updated this PR as following:
|
This patch contains following modifications: