Skip to content

TEZ-4300: Download protoc automatically compile/development time - #115

Merged
jteagles merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4300
Feb 18, 2022
Merged

TEZ-4300: Download protoc automatically compile/development time#115
jteagles merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4300

Conversation

@abstractdog

Copy link
Copy Markdown
Contributor

No description provided.

@hadoop-yetus

This comment has been minimized.

@hadoop-yetus

This comment has been minimized.

@abstractdog
abstractdogforce-pushed the TEZ-4300 branch 2 times, most recently from 5ccd57c to bd37444CompareApril 2, 2021 08:03
@hadoop-yetus

This comment has been minimized.

@hadoop-yetus

This comment has been minimized.

@hadoop-yetus

This comment has been minimized.

@hadoop-yetus

This comment has been minimized.

@tez-yetus

This comment has been minimized.

@tez-yetus

This comment was marked as outdated.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

what do you think about this @jteagles? this would help with automatically handling different protoc versions, driven only by protobuf.version property

@jteagles

Copy link
Copy Markdown
Contributor

@abstractdog, As a project, is this needed only for Hadoop 3.x projects or is there value in branch-0.9 hadoop 2.x based projects?

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

it makes sense to try the patch out on branch-0.9 as it's only about using protobuf inside tez, let me try

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

checked, the patch works on branch-0.9 too, this commit

contains a fix that I added on master too, please refer to the second commit: moved the profile to root pom.xml + redefined where it was needed

is this okay to go in?

@tez-yetus

This comment was marked as outdated.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

@jteagles : can I merge this to master? and push it to branch-0.9

@tez-yetus

This comment was marked as outdated.

@abstractdog
abstractdogforce-pushed the TEZ-4300 branch 2 times, most recently from fad5021 to 9f3f3c8CompareFebruary 18, 2022 12:11
@tez-yetus

This comment was marked as outdated.

@abstractdog

abstractdog commented Feb 18, 2022

Copy link
Copy Markdown
ContributorAuthor

@jteagles : could you please approve this patch?
the installer script has been updated according to comments in Jira, now it supports aarch64 too

@tez-yetus

This comment was marked as outdated.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep5m 29sMaven dependency ordering for branch
+1 💚mvninstall9m 21smaster passed
+1 💚compile3m 37smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚compile3m 12smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javadoc3m 28smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc2m 48smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall5m 20sthe patch passed
+1 💚compile3m 34sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javac3m 34sthe patch passed
+1 💚compile3m 14sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac3m 14sthe patch passed
-1 ❌shellcheck0m 0sThe patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 4sThe patch has no ill-formed XML file.
+1 💚javadoc3m 20sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc2m 46sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
_ Other Tests _
+1 💚unit2m 20stez-api in the patch passed.
+1 💚unit0m 36stez-protobuf-history-plugin in the patch passed.
+1 💚unit70m 14sroot in the patch passed.
+1 💚asflicense1m 21sThe patch does not generate ASF License warnings.
122m 58s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-115/13/artifact/out/Dockerfile
GITHUB PR#115
JIRA IssueTEZ-4300
Optional Testsdupname asflicense shellcheck shelldocs javac javadoc unit xml compile
unameLinux a7c009e00555 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / a495fb6
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
shellcheckhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-115/13/artifact/out/diff-patch-shellcheck.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-115/13/testReport/
Max. process+thread count2099 (vs. ulimit of 5500)
modulesC: tez-api tez-plugins/tez-protobuf-history-plugin . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-115/13/console
versionsgit=2.25.1 maven=3.6.3 shellcheck=0.7.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@jteaglesjteagles left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Let's try this out.

@jteagles
jteagles merged commit 5241f58 into apache:masterFeb 18, 2022
LA-Toth added a commit to LA-Toth/tez that referenced this pull request Feb 22, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@abstractdog@hadoop-yetus@tez-yetus@jteagles