Uh oh!
There was an error while loading. Please reload this page.
TEZ-4300: Download protoc automatically compile/development time - #115
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
5ccd57c to
bd37444Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
abstractdog
commented
Dec 27, 2021
what do you think about this @jteagles? this would help with automatically handling different protoc versions, driven only by protobuf.version property |
jteagles
commented
Jan 5, 2022
@abstractdog, As a project, is this needed only for Hadoop 3.x projects or is there value in branch-0.9 hadoop 2.x based projects? |
abstractdog
commented
Jan 5, 2022
it makes sense to try the patch out on branch-0.9 as it's only about using protobuf inside tez, let me try |
abstractdog
commented
Jan 6, 2022
checked, the patch works on branch-0.9 too, this commit contains a fix that I added on master too, please refer to the second commit: moved the profile to root pom.xml + redefined where it was needed is this okay to go in? |
This comment was marked as outdated.
This comment was marked as outdated.
abstractdog
commented
Jan 12, 2022
@jteagles : can I merge this to master? and push it to branch-0.9 |
This comment was marked as outdated.
This comment was marked as outdated.
fad5021 to
9f3f3c8Compare
This comment was marked as outdated.
This comment was marked as outdated.
@jteagles : could you please approve this patch? |
This comment was marked as outdated.
This comment was marked as outdated.
tez-yetus
commented
Feb 18, 2022
💔 -1 overall
This message was automatically generated. |
…ime (apache#115)" This reverts commit 5241f58.
No description provided.