Skip to content

Could org.apache.tez:hadoop-shim:0.10.1-SNAPSHOT drop off redundant dependencies to loose weight? - #127

Open
Celebrate-future wants to merge 1 commit into
apache:masterfrom
Celebrate-future:master
Open

Could org.apache.tez:hadoop-shim:0.10.1-SNAPSHOT drop off redundant dependencies to loose weight? #127
Celebrate-future wants to merge 1 commit into
apache:masterfrom
Celebrate-future:master

Conversation

@Celebrate-future

@Celebrate-futureCelebrate-future commented May 21, 2021

Copy link
Copy Markdown

@abstractdog Hi, I am a user of project org.apache.tez:hadoop-shim:0.10.1-SNAPSHOT. I found that its pom file introduced 82 dependencies. However, among them, 9 libraries (10%) have not been used by your project (the redundant dependencies are listed below). Reduce these useless dependencies can help prevent conflicts between library versions. MeanWhile, it can minimize the total added size to projects. It can also help enable advanced scenarios for users of your package.
This PR helps org.apache.tez:hadoop-shim:0.10.1-SNAPSHOT lose weight :) I have tested the revised configuration in my local environment. It is safe to remove the unused libraries.

Best regards

Redundant dependencies----


javax.xml.bind:jaxb-api:jar:2.2.11:compile
javax.servlet:javax.servlet-api:jar:3.1.0:compile
com.sun.jersey:jersey-servlet:jar:1.19:compile
com.sun.jersey:jersey-json:jar:1.19:compile
org.codehaus.jettison:jettison:jar:1.3.4:compile
com.sun.xml.bind:jaxb-impl:jar:2.2.3-1:compile
org.codehaus.jackson:jackson-jaxrs:jar:1.9.2:compile
org.codehaus.jackson:jackson-xc:jar:1.9.2:compile
org.apache.kerby:kerby-xdr:jar:1.0.1:compile

Vulnerable libraries

org.codehaus.jettison:jettison:1.3.4 (CVE-2022-45693)

Outdated dependencies

com.sun.jersey:jersey-json:1.19 (3090 days without maintenance)
javax.servlet:javax.servlet-api:3.1.0 (3746 days without maintenance)
javax.xml.bind:jaxb-api:2.2.11 (3613 days without maintenance)
org.codehaus.jackson:jackson-jaxrs:1.9.2 (4284 days without maintenance)
org.apache.kerby:kerby-xdr:1.0.1 (2159 days without maintenance)

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec14m 10sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall13m 5smaster passed
+1 💚compile0m 22smaster passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚compile0m 22smaster passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚javadoc0m 47smaster passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc0m 23smaster passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
_ Patch Compile Tests _
+1 💚mvninstall0m 15sthe patch passed
+1 💚compile0m 13sthe patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javac0m 13sthe patch passed
+1 💚compile0m 11sthe patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚javac0m 11sthe patch passed
-1 ❌whitespace0m 0sThe patch 1 line(s) with tabs.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚javadoc0m 12sthe patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc0m 10sthe patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
_ Other Tests _
+1 💚unit0m 19shadoop-shim in the patch passed.
+1 💚asflicense0m 16sThe patch does not generate ASF License warnings.
31m 33s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-127/1/artifact/out/Dockerfile
GITHUB PR#127
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux 99d5bb331936 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 0af54df
Default JavaPrivate Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
whitespacehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-127/1/artifact/out/whitespace-tabs.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-127/1/testReport/
Max. process+thread count99 (vs. ulimit of 5500)
modulesC: hadoop-shim U: hadoop-shim
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-127/1/console
versionsgit=2.25.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
Contributor

thanks for the patch @Celebrate-future
in general, there is a good idea to exclude not used transitive dependencies
could you please create a Jira for this PR?

@Celebrate-future

Copy link
Copy Markdown
Author

thanks for the patch @Celebrate-future
in general, there is a good idea to exclude not used transitive dependencies
could you please create a Jira for this PR?

Thanks for your feedback. I will finish it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Celebrate-future@hadoop-yetus@abstractdog