Skip to content

TEZ-4298: ShuffleHandler is not source compatible with Hadoop 3.3.0 - #129

Merged
jteagles merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4298
Jun 22, 2021
Merged

TEZ-4298: ShuffleHandler is not source compatible with Hadoop 3.3.0#129
jteagles merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4298

Conversation

@abstractdog

Copy link
Copy Markdown
Contributor

No description provided.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall12m 8smaster passed
+1 💚compile0m 29smaster passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚compile0m 29smaster passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚checkstyle1m 7smaster passed
+1 💚javadoc0m 38smaster passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc0m 24smaster passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+0 🆗spotbugs1m 6sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs1m 4smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 28sthe patch passed
+1 💚compile0m 16sthe patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javac0m 16sthe patch passed
+1 💚compile0m 15sthe patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚javac0m 15sthe patch passed
+1 💚checkstyle0m 10sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚javadoc0m 12sthe patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc0m 11sthe patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚findbugs0m 35sthe patch passed
_ Other Tests _
+1 💚unit2m 40stez-aux-services in the patch passed.
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
22m 48s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-129/1/artifact/out/Dockerfile
GITHUB PR#129
JIRA IssueTEZ-4298
Optional Testsdupname asflicense xml javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux e2f60d68ec62 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 0af54df
Default JavaPrivate Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-129/1/testReport/
Max. process+thread count1420 (vs. ulimit of 5500)
modulesC: tez-plugins/tez-aux-services U: tez-plugins/tez-aux-services
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-129/1/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

@jteagles: what do you think about this? TestShuffleHandlerJobs passes with this precommit job (as well as locally)
if this is committed, I can try to proceed with Hadoop 3.3.x upgrade

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

@jteagles: what do you think about this? TestShuffleHandlerJobs passes with this precommit job (as well as locally)
if this is committed, I can try to proceed with Hadoop 3.3.x upgrade

@jteagles: could you please take a look? thanks

@aajisakaaajisaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (non-binding)

@jteaglesjteagles left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! +1

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@abstractdog@hadoop-yetus@aajisaka@jteagles