Skip to content

TEZ-4311: Bump hadoop dependency version to 3.3.x - #132

Merged
abstractdog merged 2 commits into
apache:masterfrom
abstractdog:TEZ-4311
Jan 6, 2022
Merged

TEZ-4311: Bump hadoop dependency version to 3.3.x#132
abstractdog merged 2 commits into
apache:masterfrom
abstractdog:TEZ-4311

Conversation

@abstractdog

Copy link
Copy Markdown
Contributor

No description provided.

@hadoop-yetus

This comment has been minimized.

@belugabehr

Copy link
Copy Markdown
Contributor

Hey, just FYI. I came across this issue when upgrading Hive 3.3.1:

https://issues.apache.org/jira/browse/HIVE-24484?focusedCommentId=17371600&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17371600

Probably needs to be handled by Tez unless HADOOP-17779 is accepted (and released in a subsequent version).

@jteagles

Copy link
Copy Markdown
Contributor

@abstractdog, if we are to start hadoop 3.3 changes we should consider branching branch-0.10. Here's a thought. Instead of calling it 0.11 for hadoop 3.3 support, what if we change version on master to 3.3 to reflect hadoop compatibility.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

@abstractdog, if we are to start hadoop 3.3 changes we should consider branching branch-0.10. Here's a thought. Instead of calling it 0.11 for hadoop 3.3 support, what if we change version on master to 3.3 to reflect hadoop compatibility.

I like the idea, especially because tez is battle-tested and stable for a very long time, deserves more than 0.x
however, this is a historical change, we're in the 0.x line since the very beginning, so I would ask the community if anyone has a strong opinion about this (interested in pros/cons, or an alternative versioning idea if any)

@belugabehr

Copy link
Copy Markdown
Contributor

Hey Guys,

I would be careful hitching the wagon to any other projects. I think it's helpful to be on your own release cadence. However, I think 1.0 is a good first step and would lead the way to some more thoughtful approach to backwards compatibility and stableness (not that these things aren't true now, but it make it more formalized for new folks).

Thanks.

@tez-yetus

This comment has been minimized.

@tez-yetus

This comment has been minimized.

@tez-yetus

This comment has been minimized.

@abstractdog

abstractdog commented Oct 27, 2021

Copy link
Copy Markdown
ContributorAuthor

new failures are found in ShuffleHandler while running tests:

java.lang.NoSuchMethodError: io.netty.buffer.ByteBuf.forEachByte(Lio/netty/buffer/ByteBufProcessor;)I
at io.netty.handler.codec.http.HttpObjectDecoder$HeaderParser.parse(HttpObjectDecoder.java:791)
at io.netty.handler.codec.http.HttpObjectDecoder$LineParser.parse(HttpObjectDecoder.java:840)
at io.netty.handler.codec.http.HttpObjectDecoder.decode(HttpObjectDecoder.java:208)
at io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:505)
at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:444)
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:283)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:374)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:360)
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:352)
at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1422)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:374)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:360)
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:931)
at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:163)
at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:700)
at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:635)
at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:552)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:514)
at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
at java.base/java.lang.Thread.run(Thread.java:834)

full log file is attached to JIRA: https://issues.apache.org/jira/secure/attachment/13035409/org.apache.tez.auxservices.TestShuffleHandler-output.txt

@tez-yetus

This comment has been minimized.

@tez-yetus

This comment has been minimized.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

current unit test failure is reproduced as:

 mvn clean test -Dtest=TestATSHistoryWithACLs#testDAGACls -pl ./tez-plugins/tez-yarn-timeline-history-with-acls

related to YARN-9554, it's under investigation

@tez-yetus

This comment has been minimized.

@tez-yetus

This comment has been minimized.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec13m 15sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 3 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep5m 2sMaven dependency ordering for branch
+1 💚mvninstall8m 22smaster passed
+1 💚compile4m 18smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚compile4m 3smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle2m 47smaster passed
+1 💚javadoc4m 12smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc3m 33smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗spotbugs5m 27sUsed deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗findbugs5m 23sroot in master has 2 extant findbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep1m 25sMaven dependency ordering for patch
+1 💚mvninstall5m 9sthe patch passed
+1 💚compile4m 20sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javac4m 20sthe patch passed
+1 💚compile4m 4sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac4m 4sthe patch passed
+1 💚checkstyle2m 27sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+1 💚javadoc4m 0sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc3m 35sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚findbugs9m 28sthe patch passed
_ Other Tests _
+1 💚unit2m 18stez-api in the patch passed.
+1 💚unit5m 35stez-runtime-library in the patch passed.
+1 💚unit45m 53stez-tests in the patch passed.
+1 💚unit2m 1stez-yarn-timeline-history-with-acls in the patch passed.
+1 💚unit77m 57sroot in the patch passed.
+1 💚asflicense2m 14sThe patch does not generate ASF License warnings.
227m 31s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-132/9/artifact/out/Dockerfile
GITHUB PR#132
JIRA IssueTEZ-4311
Optional Testsdupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle
unameLinux 506d36c30493 4.15.0-161-generic #169-Ubuntu SMP Fri Oct 15 13:41:54 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 7e09dfa
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-132/9/testReport/
Max. process+thread count2099 (vs. ulimit of 5500)
modulesC: tez-api tez-runtime-library tez-tests tez-plugins/tez-yarn-timeline-history-with-acls . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-132/9/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

@jteagles: could you please take a look at the commits?
finally, it looks like we're quite close to the hadoop 3.3.x upgrade, because several issues were solved in hadoop 3.3.1 (that were present in 3.3.0), now I got a clean precommit test run here

@jteaglesjteagles left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I feel we are ready for this change. Probably we should plan a release once we can certify

@abstractdog

abstractdog commented Jan 6, 2022

Copy link
Copy Markdown
ContributorAuthor

thanks @jteagles, I'm about to commit this soon
just double-checked, the new code can still be successfully built with the older hadoop:

mvn clean install -DskipTests -Dhadoop.version=3.2.2

@abstractdog
abstractdog merged commit a6a936d into apache:masterJan 6, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@abstractdog@hadoop-yetus@belugabehr@jteagles@tez-yetus