Skip to content

[TEZ-4315] rectifying the potential risk of ConcurrentModificationException when getMatchingRequestWithoutPriority - #133

Open
chenjunbiao001 wants to merge 1 commit into
apache:masterfrom
chenjunbiao001:master
Open

[TEZ-4315] rectifying the potential risk of ConcurrentModificationException when getMatchingRequestWithoutPriority#133
chenjunbiao001 wants to merge 1 commit into
apache:masterfrom
chenjunbiao001:master

Conversation

@chenjunbiao001

@chenjunbiao001chenjunbiao001 commented Jun 24, 2021

Copy link
Copy Markdown

ConcurrentModificationException when getMatchingRequestWithoutPriority
@chenjunbiao001chenjunbiao001 changed the title rectifying the potential risk ofrectifying the potential risk of ConcurrentModificationException when getMatchingRequestWithoutPrioritJun 24, 2021
@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec14m 22sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall13m 10smaster passed
+1 💚compile0m 44smaster passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚compile0m 35smaster passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚checkstyle1m 17smaster passed
+1 💚javadoc0m 46smaster passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc0m 36smaster passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+0 🆗spotbugs1m 44sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs1m 42smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 28sthe patch passed
+1 💚compile0m 31sthe patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javac0m 31sthe patch passed
+1 💚compile0m 25sthe patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚javac0m 25sthe patch passed
+1 💚checkstyle0m 22stez-dag: The patch generated 0 new + 97 unchanged - 2 fixed = 97 total (was 99)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 25sthe patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc0m 23sthe patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚findbugs1m 16sthe patch passed
_ Other Tests _
+1 💚unit4m 29stez-dag in the patch passed.
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
42m 40s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-133/1/artifact/out/Dockerfile
GITHUB PR#133
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux 681a0071a93e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / d443ae2
Default JavaPrivate Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-133/1/testReport/
Max. process+thread count188 (vs. ulimit of 5500)
modulesC: tez-dag U: tez-dag
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-133/1/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@jteaglesjteagles changed the title rectifying the potential risk of ConcurrentModificationException when getMatchingRequestWithoutPriorit[TEZ-4315] rectifying the potential risk of ConcurrentModificationException when getMatchingRequestWithoutPriorityJun 25, 2021
@jteagles

Copy link
Copy Markdown
Contributor

How often have you observed the ConcurrentModificationException? When I look at the code base, the callers of those functions are synchronized at the function level. Please 1) attach a stack trace if possible or 2) create a test that shows how this is possible or 3) Explain the code path more precisely.

@jteagles

Copy link
Copy Markdown
Contributor

@chenjunbiao001, can can provide a stack trace of the ConcurrentModificationException? I am unable to find a code path that will exercise the problem in practice.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@chenjunbiao001@hadoop-yetus@jteagles