Skip to content

TEZ-4319. Add explicit dependency on snappy-java to tez-api. - #137

Merged
ayushtkn merged 1 commit into
apache:masterfrom
iwasakims:TEZ-4319
Dec 24, 2024
Merged

TEZ-4319. Add explicit dependency on snappy-java to tez-api.#137
ayushtkn merged 1 commit into
apache:masterfrom
iwasakims:TEZ-4319

Conversation

@iwasakims

Copy link
Copy Markdown
Member

https://issues.apache.org/jira/browse/TEZ-4319

Implicit dependency on snappy-java-1.0.5 was added by TEZ-4113. It causes error on platforms like aarch64 for which snappy binary is not provided.

Adding explicit dependency on recent snappy-java supporting aarch64 and ppc64le should address the issue.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec12m 42sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep5m 39sMaven dependency ordering for branch
+1 💚mvninstall8m 47smaster passed
+1 💚compile2m 47smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚compile2m 38smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javadoc2m 47smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc2m 15smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall4m 20sthe patch passed
+1 💚compile2m 49sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javac2m 49sthe patch passed
+1 💚compile2m 37sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac2m 37sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 3sThe patch has no ill-formed XML file.
+1 💚javadoc2m 35sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc2m 14sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
_ Other Tests _
+1 💚unit2m 17stez-api in the patch passed.
-1 ❌unit14m 2sroot in the patch failed.
+1 💚asflicense0m 53sThe patch does not generate ASF License warnings.
70m 50s
ReasonTests
Failed junit teststez.dag.app.TestSpeculation
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-137/1/artifact/out/Dockerfile
GITHUB PR#137
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux f4c2a7561712 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 6d7ef20
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
unithttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-137/1/artifact/out/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-137/1/testReport/
Max. process+thread count1584 (vs. ulimit of 5500)
modulesC: tez-api . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-137/1/console
versionsgit=2.25.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Comment threadpom.xml Outdated
<slf4j.version>1.7.30</slf4j.version>
<protobuf.version>2.5.0</protobuf.version>
<roaringbitmap.version>0.7.45</roaringbitmap.version>
<snappy-java.version>1.1.8.4</snappy-java.version>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iwasakims If you have a use case, and if you feel this would help, we can bump it to 1.1.10.4 like in HADOOP-18912 to be in sync with Hadoop & merge

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayushtkn I rebased the patch and updated the version of snappy-java. Thanks for the suggestion.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 8sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep3m 47sMaven dependency ordering for branch
+1 💚mvninstall10m 24smaster passed
+1 💚compile1m 36smaster passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚compile1m 33smaster passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
+1 💚javadoc1m 19smaster passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚javadoc1m 11smaster passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 33sthe patch passed
+1 💚compile1m 38sthe patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚javac1m 38sthe patch passed
+1 💚compile1m 38sthe patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
+1 💚javac1m 38sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚javadoc1m 4sthe patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04
+1 💚javadoc1m 7sthe patch passed with JDK Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
_ Other Tests _
+1 💚unit2m 0stez-api in the patch passed.
-1 ❌unit66m 36sroot in the patch failed.
+1 💚asflicense0m 47sThe patch does not generate ASF License warnings.
98m 27s
ReasonTests
Failed junit teststez.analyzer.TestAnalyzer
SubsystemReport/Notes
DockerClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-137/2/artifact/out/Dockerfile
GITHUB PR#137
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux 88a6cf6fcc34 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / fd6f152
Default JavaPrivate Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-gaus1-0ubuntu222.04-ga
unithttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-137/2/artifact/out/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-137/2/testReport/
Max. process+thread count1546 (vs. ulimit of 5500)
modulesC: tez-api . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-137/2/console
versionsgit=2.34.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ayushtknayushtkn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayushtkn
ayushtkn merged commit d39603c into apache:masterDec 24, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@iwasakims@tez-yetus@ayushtkn