Skip to content

TEZ-4321: Do Not Wrap Singleton Collections - #138

Merged
jteagles merged 1 commit into
apache:masterfrom
belugabehr:TEZ-4321
Aug 9, 2021
Merged

TEZ-4321: Do Not Wrap Singleton Collections#138
jteagles merged 1 commit into
apache:masterfrom
belugabehr:TEZ-4321

Conversation

@belugabehr

Copy link
Copy Markdown
Contributor

Singleton Collections are by their design immutable. There is no need to wrap them in an unmodifiableCollection.

@hadoop-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec12m 49sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 1sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚mvninstall13m 40smaster passed
+1 💚compile0m 45smaster passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚compile0m 37smaster passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚checkstyle1m 15smaster passed
+1 💚javadoc0m 44smaster passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc0m 34smaster passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+0 🆗spotbugs1m 41sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs1m 39smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 25sthe patch passed
+1 💚compile0m 29sthe patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javac0m 29sthe patch passed
+1 💚compile0m 25sthe patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚javac0m 25sthe patch passed
-0 ⚠️checkstyle0m 18stez-dag: The patch generated 3 new + 25 unchanged - 3 fixed = 28 total (was 28)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 22sthe patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc0m 21sthe patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚findbugs1m 10sthe patch passed
_ Other Tests _
+1 💚unit4m 18stez-dag in the patch passed.
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
40m 57s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-138/1/artifact/out/Dockerfile
GITHUB PR#138
JIRA IssueTEZ-4321
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux 0793fa824611 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 464d86d
Default JavaPrivate Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-138/1/artifact/out/diff-checkstyle-tez-dag.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-138/1/testReport/
Max. process+thread count209 (vs. ulimit of 5500)
modulesC: tez-dag U: tez-dag
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-138/1/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@tez-yetus

Copy link
Copy Markdown

+1. Good catch.

@jteagles
jteagles merged commit f56075c into apache:masterAug 9, 2021
asfgit pushed a commit that referenced this pull request Aug 9, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@belugabehr@hadoop-yetus@tez-yetus@jteagles