Skip to content

TEZ-4318: Tez debugging tools webapp - #139

Open
abstractdog wants to merge 1 commit into
apache:masterfrom
abstractdog:TEZ-4318
Open

TEZ-4318: Tez debugging tools webapp#139
abstractdog wants to merge 1 commit into
apache:masterfrom
abstractdog:TEZ-4318

Conversation

@abstractdog

Copy link
Copy Markdown
Contributor

No description provided.

@abstractdog
abstractdogforce-pushed the TEZ-4318 branch 2 times, most recently from 8488628 to 1946215CompareAugust 1, 2021 12:52
@hadoop-yetus

This comment has been minimized.

@hadoop-yetus

This comment has been minimized.

@hadoop-yetus

This comment has been minimized.

@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 1sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep5m 10sMaven dependency ordering for branch
+1 💚mvninstall8m 35smaster passed
+1 💚compile4m 0smaster passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚compile3m 46smaster passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚checkstyle2m 17smaster passed
+1 💚javadoc3m 44smaster passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc2m 55smaster passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+0 🆗spotbugs0m 41sUsed deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗findbugs0m 47stez-tools in master has 2 extant findbugs warnings.
+0 🆗findbugs5m 48sroot in master has 2 extant findbugs warnings.
+0 🆗findbugs0m 39stez-tools/analyzers/job-analyzer in master has 4 extant findbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep1m 54sMaven dependency ordering for patch
+1 💚mvninstall5m 55sthe patch passed
+1 💚compile4m 27sthe patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javac4m 27sthe patch passed
+1 💚compile4m 8sthe patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚javac4m 8sthe patch passed
-0 ⚠️checkstyle0m 25stez-tools: The patch generated 9 new + 47 unchanged - 0 fixed = 56 total (was 47)
-0 ⚠️checkstyle0m 24stez-tools/analyzers/job-analyzer: The patch generated 1 new + 47 unchanged - 0 fixed = 48 total (was 47)
-0 ⚠️checkstyle0m 22stez-tools/tez-tools-webapp: The patch generated 8 new + 0 unchanged - 0 fixed = 8 total (was 0)
-0 ⚠️checkstyle0m 49sroot: The patch generated 9 new + 55 unchanged - 0 fixed = 64 total (was 55)
+1 💚hadolint0m 1sThere were no new hadolint issues.
+1 💚markdownlint0m 1sThere were no new markdownlint issues.
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 7sThe patch has no ill-formed XML file.
+1 💚javadoc3m 55sthe patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc3m 24sthe patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
-1 ❌findbugs1m 8stez-tools generated 4 new + 2 unchanged - 0 fixed = 6 total (was 2)
-1 ❌findbugs5m 53sroot generated 4 new + 2 unchanged - 0 fixed = 6 total (was 2)
_ Other Tests _
+1 💚unit2m 38stez-history-parser in the patch passed.
+1 💚unit2m 49stez-tools in the patch passed.
+1 💚unit2m 48sjob-analyzer in the patch passed.
+1 💚unit0m 30stez-tools-webapp in the patch passed.
+1 💚unit75m 0sroot in the patch passed.
-1 ❌asflicense2m 15sThe patch generated 5 ASF License warnings.
163m 30s
ReasonTests
FindBugsmodule:tez-tools
Found reliance on default encoding in org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String):in org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String): new java.io.FileReader(String) At AnalyzerService.java:[line 158]
Inconsistent synchronization of org.apache.tez.tools.webapp.service.AnalyzerService.analyzers; locked 80% of time Unsynchronized access at AnalyzerService.java:80% of time Unsynchronized access at AnalyzerService.java:[line 81]
Possible null pointer dereference in org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String) due to return value of called method Dereferenced at AnalyzerService.java:org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String) due to return value of called method Dereferenced at AnalyzerService.java:[line 155]
org.apache.tez.tools.webapp.service.AnalyzerService.addFileToZip(File, ZipOutputStream) may fail to clean up java.io.InputStream on checked exception Obligation to clean up resource created at AnalyzerService.java:clean up java.io.InputStream on checked exception Obligation to clean up resource created at AnalyzerService.java:[line 199] is not discharged
FindBugsmodule:root
Found reliance on default encoding in org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String):in org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String): new java.io.FileReader(String) At AnalyzerService.java:[line 158]
Inconsistent synchronization of org.apache.tez.tools.webapp.service.AnalyzerService.analyzers; locked 80% of time Unsynchronized access at AnalyzerService.java:80% of time Unsynchronized access at AnalyzerService.java:[line 81]
Possible null pointer dereference in org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String) due to return value of called method Dereferenced at AnalyzerService.java:org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String) due to return value of called method Dereferenced at AnalyzerService.java:[line 155]
org.apache.tez.tools.webapp.service.AnalyzerService.addFileToZip(File, ZipOutputStream) may fail to clean up java.io.InputStream on checked exception Obligation to clean up resource created at AnalyzerService.java:clean up java.io.InputStream on checked exception Obligation to clean up resource created at AnalyzerService.java:[line 199] is not discharged
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/4/artifact/out/Dockerfile
GITHUB PR#139
JIRA IssueTEZ-4318
Optional Testsdupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle hadolint shellcheck shelldocs markdownlint
unameLinux 7d6bca12fc98 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 3f541d0
Default JavaPrivate Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/4/artifact/out/diff-checkstyle-tez-tools.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/4/artifact/out/diff-checkstyle-tez-tools_analyzers_job-analyzer.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/4/artifact/out/diff-checkstyle-tez-tools_tez-tools-webapp.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/4/artifact/out/diff-checkstyle-root.txt
findbugshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/4/artifact/out/new-findbugs-tez-tools.html
findbugshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/4/artifact/out/new-findbugs-root.html
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/4/testReport/
asflicensehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/4/artifact/out/patch-asflicense-problems.txt
Max. process+thread count2099 (vs. ulimit of 5500)
modulesC: tez-plugins/tez-history-parser tez-tools tez-tools/analyzers/job-analyzer tez-tools/tez-tools-webapp . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/4/console
versionsgit=2.25.1 maven=3.6.3 shellcheck=0.7.1 findbugs=3.0.1 hadolint=1.18.0-0-g76eee5c markdownlint=0.23.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apacheapache deleted a comment from tez-yetusAug 10, 2021
@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec12m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep5m 20sMaven dependency ordering for branch
+1 💚mvninstall8m 30smaster passed
+1 💚compile3m 44smaster passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚compile3m 32smaster passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚checkstyle2m 19smaster passed
+1 💚javadoc3m 36smaster passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc2m 54smaster passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+0 🆗spotbugs0m 42sUsed deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗findbugs0m 46stez-tools in master has 2 extant findbugs warnings.
+0 🆗findbugs5m 27sroot in master has 2 extant findbugs warnings.
+0 🆗findbugs0m 39stez-tools/analyzers/job-analyzer in master has 4 extant findbugs warnings.
_ Patch Compile Tests _
+0 🆗mvndep1m 59sMaven dependency ordering for patch
+1 💚mvninstall5m 51sthe patch passed
+1 💚compile4m 26sthe patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javac4m 26sthe patch passed
+1 💚compile4m 5sthe patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚javac4m 5sthe patch passed
-0 ⚠️checkstyle0m 25stez-tools: The patch generated 7 new + 47 unchanged - 0 fixed = 54 total (was 47)
-0 ⚠️checkstyle0m 24stez-tools/analyzers/job-analyzer: The patch generated 1 new + 47 unchanged - 0 fixed = 48 total (was 47)
-0 ⚠️checkstyle0m 22stez-tools/tez-tools-webapp: The patch generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
-0 ⚠️checkstyle0m 49sroot: The patch generated 7 new + 55 unchanged - 0 fixed = 62 total (was 55)
+1 💚hadolint0m 1sThere were no new hadolint issues.
-1 ❌markdownlint0m 0sThe patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 7sThe patch has no ill-formed XML file.
+1 💚javadoc3m 59sthe patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc3m 25sthe patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
-1 ❌findbugs1m 8stez-tools generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
-1 ❌findbugs5m 51sroot generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
_ Other Tests _
+1 💚unit2m 39stez-history-parser in the patch passed.
+1 💚unit2m 50stez-tools in the patch passed.
+1 💚unit2m 48sjob-analyzer in the patch passed.
+1 💚unit0m 30stez-tools-webapp in the patch passed.
+1 💚unit76m 21sroot in the patch passed.
-1 ❌asflicense2m 15sThe patch generated 1 ASF License warnings.
176m 1s
ReasonTests
FindBugsmodule:tez-tools
Possible null pointer dereference in org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String) due to return value of called method Dereferenced at AnalyzerService.java:org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String) due to return value of called method Dereferenced at AnalyzerService.java:[line 156]
FindBugsmodule:root
Possible null pointer dereference in org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String) due to return value of called method Dereferenced at AnalyzerService.java:org.apache.tez.tools.webapp.service.AnalyzerService.convertCSVFileToExcel(String) due to return value of called method Dereferenced at AnalyzerService.java:[line 156]
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/artifact/out/Dockerfile
GITHUB PR#139
JIRA IssueTEZ-4318
Optional Testsdupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle hadolint shellcheck shelldocs markdownlint
unameLinux 5a84c9e43c66 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / fc63c04
Default JavaPrivate Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/artifact/out/diff-checkstyle-tez-tools.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/artifact/out/diff-checkstyle-tez-tools_analyzers_job-analyzer.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/artifact/out/diff-checkstyle-tez-tools_tez-tools-webapp.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/artifact/out/diff-checkstyle-root.txt
markdownlinthttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/artifact/out/diff-patch-markdownlint.txt
findbugshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/artifact/out/new-findbugs-tez-tools.html
findbugshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/artifact/out/new-findbugs-root.html
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/testReport/
asflicensehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/artifact/out/patch-asflicense-problems.txt
Max. process+thread count1463 (vs. ulimit of 5500)
modulesC: tez-plugins/tez-history-parser tez-tools tez-tools/analyzers/job-analyzer tez-tools/tez-tools-webapp . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-139/5/console
versionsgit=2.25.1 maven=3.6.3 shellcheck=0.7.1 findbugs=3.0.1 hadolint=1.18.0-0-g76eee5c markdownlint=0.23.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@abstractdog@hadoop-yetus@tez-yetus