TEZ-4342: TestSecureShuffle is broken

[abstractdog]

No description provided.

[tez-yetus]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	12m 46s	master passed
+1 💚	compile	0m 33s	master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	0m 31s	master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	1m 6s	master passed
+1 💚	javadoc	0m 39s	master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 27s	master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+0 🆗	spotbugs	1m 11s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	1m 9s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 19s	the patch passed
+1 💚	compile	0m 17s	the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	0m 17s	the patch passed
+1 💚	compile	0m 16s	the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	0m 16s	the patch passed
-0 ⚠️	checkstyle	0m 11s	tez-tests: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 14s	the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 12s	the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	findbugs	0m 38s	the patch passed
		_ Other Tests _
+1 💚	unit	46m 44s	tez-tests in the patch passed.
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		68m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-158/1/artifact/out/Dockerfile
GITHUB PR	#158
JIRA Issue	TEZ-4342
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname	Linux ec2a826ae6e1 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/tez.sh
git revision	master / 58fca8b
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
checkstyle	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-158/1/artifact/out/diff-checkstyle-tez-tests.txt
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-158/1/testReport/
Max. process+thread count	1411 (vs. ulimit of 5500)
modules	C: tez-tests U: tez-tests
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-158/1/console
versions	git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[rbalamohan]

+1

[abstractdog]

thanks @rbalamohan for the quick review! I've just pushed an addendum commit with some comments and a checkstyle fix, then I'll merge this later

[tez-yetus]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	12m 42s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	14m 52s	master passed
+1 💚	compile	0m 32s	master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	0m 32s	master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	1m 5s	master passed
+1 💚	javadoc	0m 48s	master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 26s	master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+0 🆗	spotbugs	1m 41s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	1m 40s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 17s	the patch passed
+1 💚	compile	0m 18s	the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	0m 18s	the patch passed
+1 💚	compile	0m 17s	the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	0m 17s	the patch passed
+1 💚	checkstyle	0m 10s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 13s	the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 12s	the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	findbugs	0m 40s	the patch passed
		_ Other Tests _
+1 💚	unit	41m 53s	tez-tests in the patch passed.
+1 💚	asflicense	0m 20s	The patch does not generate ASF License warnings.
		77m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-158/2/artifact/out/Dockerfile
GITHUB PR	#158
JIRA Issue	TEZ-4342
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname	Linux d92b9b2e20ba 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/tez.sh
git revision	master / 58fca8b
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-158/2/testReport/
Max. process+thread count	1318 (vs. ulimit of 5500)
modules	C: tez-tests U: tez-tests
Console output	https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-158/2/console
versions	git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.