Skip to content

TEZ-4366: Disk utilization limit fix should be applied to all tez mini clusters - #173

Merged
jteagles merged 2 commits into
apache:masterfrom
abstractdog:TEZ-4366
Jan 21, 2022
Merged

TEZ-4366: Disk utilization limit fix should be applied to all tez mini clusters#173
jteagles merged 2 commits into
apache:masterfrom
abstractdog:TEZ-4366

Conversation

@abstractdog

Copy link
Copy Markdown
Contributor

No description provided.

@tez-yetus

This comment has been minimized.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep4m 19sMaven dependency ordering for branch
+1 💚mvninstall9m 9smaster passed
+1 💚compile1m 30smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚compile1m 26smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle1m 29smaster passed
+1 💚javadoc1m 33smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc1m 16smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗spotbugs0m 41sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs2m 25smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall0m 49sthe patch passed
+1 💚compile0m 48sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javac0m 48sthe patch passed
+1 💚compile0m 45sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac0m 45sthe patch passed
+1 💚checkstyle0m 10sThe patch passed checkstyle in tez-common
+1 💚checkstyle0m 11stez-tests: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4)
+1 💚checkstyle0m 8sThe patch passed checkstyle in tez-yarn-timeline-history
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 39sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc0m 34sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚findbugs1m 45sthe patch passed
_ Other Tests _
+1 💚unit0m 32stez-common in the patch passed.
+1 💚unit44m 12stez-tests in the patch passed.
+1 💚unit1m 32stez-yarn-timeline-history in the patch passed.
+1 💚asflicense0m 34sThe patch does not generate ASF License warnings.
77m 52s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-173/2/artifact/out/Dockerfile
GITHUB PR#173
JIRA IssueTEZ-4366
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux fd67ca86a151 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 7e09dfa
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-173/2/testReport/
Max. process+thread count1341 (vs. ulimit of 5500)
modulesC: tez-common tez-tests tez-plugins/tez-yarn-timeline-history U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-173/2/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

thanks for the review @shameersss1, in order to merge it, officially a committer +1 is needed, but I appreciate you've already taken a look at this one!

@jteagles

Copy link
Copy Markdown
Contributor

Thanks, @abstractdog. I can see the value in this. I wonder if this method is better suited to a test utility, though I can't seem to find one. I can see this going in as is or Trying to find a class that is utilities just for tests. Let me know what you want.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec12m 44sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep4m 33sMaven dependency ordering for branch
+1 💚mvninstall9m 19smaster passed
+1 💚compile1m 32smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚compile1m 28smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle1m 30smaster passed
+1 💚javadoc1m 31smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc1m 18smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗spotbugs0m 41sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs2m 26smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall0m 49sthe patch passed
+1 💚compile0m 49sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javac0m 49sthe patch passed
+1 💚compile0m 46sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac0m 46sthe patch passed
-0 ⚠️checkstyle0m 10stez-common: The patch generated 1 new + 56 unchanged - 0 fixed = 57 total (was 56)
+1 💚checkstyle0m 11stez-tests: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4)
+1 💚checkstyle0m 9sThe patch passed checkstyle in tez-yarn-timeline-history
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 39sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc0m 35sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚findbugs1m 45sthe patch passed
_ Other Tests _
+1 💚unit0m 32stez-common in the patch passed.
+1 💚unit44m 23stez-tests in the patch passed.
+1 💚unit1m 32stez-yarn-timeline-history in the patch passed.
+1 💚asflicense0m 35sThe patch does not generate ASF License warnings.
90m 54s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-173/3/artifact/out/Dockerfile
GITHUB PR#173
JIRA IssueTEZ-4366
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux e4678e8b1473 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 227c750
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-173/3/artifact/out/diff-checkstyle-tez-common.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-173/3/testReport/
Max. process+thread count1329 (vs. ulimit of 5500)
modulesC: tez-common tez-tests tez-plugins/tez-yarn-timeline-history U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-173/3/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

@jteagles : could this be committed?

@jteaglesjteagles left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jteagles
jteagles merged commit 267ca11 into apache:masterJan 21, 2022
asfgit pushed a commit that referenced this pull request Jan 23, 2022
…i clusters (#173)
* TEZ-4366: Disk utilization limit fix should be applied to all tez mini clusters
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@abstractdog@tez-yetus@jteagles@shameersss1