Skip to content

TEZ-4369: Upgrade netty to 4.1.69 due to CVE-2021-37136, CVE-2021-37137 - #175

Merged
jteagles merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4369
Jan 21, 2022
Merged

TEZ-4369: Upgrade netty to 4.1.69 due to CVE-2021-37136, CVE-2021-37137#175
jteagles merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4369

Conversation

@abstractdog

Copy link
Copy Markdown
Contributor

No description provided.

@tez-yetus

This comment has been minimized.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

failure is not related:

[ERROR] org.apache.tez.runtime.library.utils.TestCodecUtils.testConcurrentDecompressorCreationWithModifiedBuffersize Time elapsed: 0.188 s <<< ERROR!
java.lang.OutOfMemoryError: unable to create new native thread
at org.apache.tez.runtime.library.utils.TestCodecUtils.testConcurrentDecompressorCreationWithModifiedBuffersizeOnCodec(TestCodecUtils.java:76)
at org.apache.tez.runtime.library.utils.TestCodecUtils.testConcurrentDecompressorCreationWithModifiedBuffersize(TestCodecUtils.java:58)

@jteagles

Copy link
Copy Markdown
Contributor

@abstractdog,
can you help understand why upgrade to this version versus later versions
https://netty.io/news/2021/10/11/4-1-70-Final.html
https://netty.io/news/2021/12/09/4-1-71-Final.html
https://netty.io/news/2021/12/13/4-1-72-Final.html

Also, I would try to track this jira https://issues.apache.org/jira/browse/HDFS-16384 which describes a possible hadoop upgrade with patch available for hadoop 3.4.0 target

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

you're right @jteagles, let's jump 4.1.72 (not to mention that 4.1.72 solves more CVE-s as far as I know)

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

@jteagles : can I commit this one?

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec16m 17sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall13m 22smaster passed
+1 💚compile2m 17smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚compile2m 4smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javadoc2m 21smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc1m 39smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
_ Patch Compile Tests _
+1 💚mvninstall4m 45sthe patch passed
+1 💚compile2m 19sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javac2m 19sthe patch passed
+1 💚compile2m 9sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac2m 9sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚javadoc1m 59sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc1m 36sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
_ Other Tests _
+1 💚unit73m 12sroot in the patch passed.
+1 💚asflicense0m 31sThe patch does not generate ASF License warnings.
125m 29s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-175/2/artifact/out/Dockerfile
GITHUB PR#175
JIRA IssueTEZ-4369
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux 481409769d11 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 41cbc17
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-175/2/testReport/
Max. process+thread count2089 (vs. ulimit of 5500)
modulesC: . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-175/2/console
versionsgit=2.25.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@jteaglesjteagles left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jteagles
jteagles merged commit 02d574f into apache:masterJan 21, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@abstractdog@tez-yetus@jteagles