Skip to content

TEZ-4384: Remove unused EnvironmentUpdateUtils remaining from TEZ-1837 - #186

Merged
abstractdog merged 1 commit into
apache:masterfrom
LA-Toth:TEZ-4384
Feb 15, 2022
Merged

TEZ-4384: Remove unused EnvironmentUpdateUtils remaining from TEZ-1837#186
abstractdog merged 1 commit into
apache:masterfrom
LA-Toth:TEZ-4384

Conversation

@LA-Toth

Copy link
Copy Markdown
Contributor

No description provided.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec16m 36sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚mvninstall13m 33smaster passed
+1 💚compile0m 23smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚compile0m 21smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle1m 0smaster passed
+1 💚javadoc0m 34smaster passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc0m 21smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗spotbugs0m 59sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs0m 56smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 14sthe patch passed
+1 💚compile0m 13sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javac0m 13sthe patch passed
+1 💚compile0m 12sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac0m 12sthe patch passed
+1 💚checkstyle0m 7stez-common: The patch generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 13sthe patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚javadoc0m 11sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚findbugs0m 34sthe patch passed
_ Other Tests _
+1 💚unit0m 29stez-common in the patch passed.
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
36m 59s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-186/1/artifact/out/Dockerfile
GITHUB PR#186
JIRA IssueTEZ-4384
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux 3270872bf338 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 7b66d3d
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-186/1/testReport/
Max. process+thread count91 (vs. ulimit of 5500)
modulesC: tez-common U: tez-common
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-186/1/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog
abstractdog self-requested a review February 14, 2022 09:19
@abstractdog

Copy link
Copy Markdown
Contributor

+1 on removing this
this environment hack should be present only if we need and use it

@abstractdog
abstractdog merged commit f62bf12 into apache:masterFeb 15, 2022
asfgit pushed a commit that referenced this pull request Feb 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@LA-Toth@tez-yetus@abstractdog