Skip to content

TEZ-4359: ShuffleHandler: Make sure of properly releasing netty reference counted objects - #194

Merged
abstractdog merged 1 commit into
apache:masterfrom
mark-bathori:TEZ-4359
Mar 10, 2022
Merged

TEZ-4359: ShuffleHandler: Make sure of properly releasing netty reference counted objects#194
abstractdog merged 1 commit into
apache:masterfrom
mark-bathori:TEZ-4359

Conversation

@mark-bathori

Copy link
Copy Markdown
Contributor

No description provided.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 12sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall13m 48smaster passed
+1 💚compile0m 26smaster passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚compile0m 24smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle0m 53smaster passed
+1 💚javadoc0m 33smaster passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc0m 20smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗spotbugs1m 1sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs0m 59smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 25sthe patch passed
+1 💚compile0m 16sthe patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚javac0m 16sthe patch passed
+1 💚compile0m 15sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac0m 15sthe patch passed
+1 💚checkstyle0m 9sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 12sthe patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
+1 💚javadoc0m 10sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚findbugs0m 35sthe patch passed
_ Other Tests _
+1 💚unit2m 42stez-aux-services in the patch passed.
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
24m 22s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-194/1/artifact/out/Dockerfile
GITHUB PR#194
JIRA IssueTEZ-4359
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux e63849a53620 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / fa74b95
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-194/1/testReport/
Max. process+thread count1399 (vs. ulimit of 5500)
modulesC: tez-plugins/tez-aux-services U: tez-plugins/tez-aux-services
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-194/1/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog
abstractdog self-requested a review March 10, 2022 19:53
@abstractdog

Copy link
Copy Markdown
Contributor

LGTM +1

@abstractdog
abstractdog merged commit 132ea4c into apache:masterMar 10, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mark-bathori@tez-yetus@abstractdog