Uh oh!
There was an error while loading. Please reload this page.
TEZ-4397 Open Tez Input splits asynchronously - #195
Merged
Conversation
tez-yetus
commented
Mar 15, 2022
💔 -1 overall
This message was automatically generated. |
| curReader = wrappedInputFormat.getRecordReader( | ||
| groupedSplit.wrappedSplits.get(idx), job, reporter); | ||
| curReader = initedReaders.poll().get(); | ||
| submitInitReaders(1); |
Contributor
There was a problem hiding this comment.
From the next stage onwards (i.e after the init part), this will start executing in sequential order as it requests for 1 additional reader. It will be good to init next set of readers in parallel.
| RecordReader<K, V> reader = wrappedInputFormat.getRecordReader(s, job, reporter); | ||
| LOG.debug("Init Thread processed reader number {} initialization", index); | ||
| return reader; | ||
| } catch(IOException e) { |
Contributor
There was a problem hiding this comment.
If thread is interrupted, it should cancel other pending tasks?
Contributor
There was a problem hiding this comment.
This should be done for all exceptions as well.
tez-yetus
commented
Mar 17, 2022
💔 -1 overall
This message was automatically generated. |
jfsii
reviewed
Mar 17, 2022
jfsii
left a comment
There was a problem hiding this comment.
Added two comments - I learned a bit reading about ThreadPools and garbage collection
| throw new RuntimeException(e); | ||
| } catch (InterruptedException e) { | ||
| Thread.currentThread().interrupt(); | ||
| for (Future<RecordReader<K,V>> f : initedReaders) { |
There was a problem hiding this comment.
probably want to cancel on any exception and thread interrupt only on InterruptedException.
| TezSplitGrouper.TEZ_GROUPING_SPLIT_INIT_THREADS_DEFAULT); | ||
| this.numReaders = conf.getInt(TezSplitGrouper.TEZ_GROUPING_SPLIT_INIT_NUM_RECORDREADERS, | ||
| TezSplitGrouper.TEZ_GROUPING_SPLIT_INIT_NUM_RECORDREADERS_DEFAULT); | ||
| this.initReaderExecService = Executors.newFixedThreadPool(numThreads, |
There was a problem hiding this comment.
I think we will want to somehow make this static (to share between usages of TezGroupedSplitsRecordReader) or figure out how to call shutdown in a reliable manner. Otherwise I think a long lived process that uses multiple TezGroupedSplitsRecordReaders throughout its life will end up having a large number of unused threads since they will not auto shutdown and thus not garbage collected.
https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ThreadPoolExecutor.html
See finalization section.
Contributor
There was a problem hiding this comment.
I'm not sure about the context, but if the goal is to properly shutdown a global resource somehow, it can done by the shutdownhandler, somewhere here: https://github.com/apache/tez/blob/master/tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java#L954
ramesh0201force-pushed
the
TEZ-4397
branch
2 times, most recently
from
March 22, 2022 06:12
214e242 to
6229a16Comparetez-yetus
commented
Mar 22, 2022
💔 -1 overall
This message was automatically generated. |
tez-yetus
commented
Mar 22, 2022
💔 -1 overall
This message was automatically generated. |
ramesh0201
commented
Mar 22, 2022
ContributorAuthor
Thanks @rbalamohan@jfsii and @abstractdog for the reviews. |
tez-yetus
commented
Mar 22, 2022
💔 -1 overall
This message was automatically generated. |
rbalamohan
commented
Mar 23, 2022
Contributor
Latest patch LGTM. +1 |
This was referenced Jul 15, 2026
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tez input splits can be opened asynchronously. This will reduce the amount of time spent for s3 to prepare the connection and opening the object