Skip to content

TEZ-4396 Ensure utility classes have only private (default) constructors - #197

Merged
abstractdog merged 1 commit into
apache:masterfrom
ghanko:TEZ-4396
Nov 26, 2022
Merged

TEZ-4396 Ensure utility classes have only private (default) constructors#197
abstractdog merged 1 commit into
apache:masterfrom
ghanko:TEZ-4396

Conversation

@ghanko

Copy link
Copy Markdown
Contributor

No description provided.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@abstractdog

Copy link
Copy Markdown
Contributor

@ghanko : is there a chance you can rebase this change and address the remaining related checkstyle issues?

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

Change-Id: I0cf2653338a74379bdfefc87430859aa114bbdfa
@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 24 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep5m 55sMaven dependency ordering for branch
+1 💚mvninstall10m 38smaster passed
+1 💚compile10m 22smaster passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚compile10m 13smaster passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚checkstyle8m 18smaster passed
+1 💚javadoc8m 37smaster passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚javadoc8m 43smaster passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+0 🆗spotbugs0m 59sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs13m 31smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall4m 54sthe patch passed
+1 💚compile4m 47sthe patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚javac4m 47sthe patch passed
+1 💚compile4m 29sthe patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚javac4m 29sthe patch passed
+1 💚checkstyle0m 21stez-api: The patch generated 0 new + 161 unchanged - 16 fixed = 161 total (was 177)
+1 💚checkstyle0m 15stez-common: The patch generated 0 new + 53 unchanged - 5 fixed = 53 total (was 58)
+1 💚checkstyle0m 13stez-runtime-internals: The patch generated 0 new + 20 unchanged - 4 fixed = 20 total (was 24)
+1 💚checkstyle0m 24stez-runtime-library: The patch generated 0 new + 234 unchanged - 67 fixed = 234 total (was 301)
+1 💚checkstyle0m 17stez-mapreduce: The patch generated 0 new + 92 unchanged - 20 fixed = 92 total (was 112)
+1 💚checkstyle0m 13stez-examples: The patch generated 0 new + 2 unchanged - 13 fixed = 2 total (was 15)
+1 💚checkstyle0m 26stez-dag: The patch generated 0 new + 152 unchanged - 16 fixed = 152 total (was 168)
+1 💚checkstyle0m 18stez-tests: The patch generated 0 new + 68 unchanged - 131 fixed = 68 total (was 199)
+1 💚checkstyle0m 12stez-ext-service-tests: The patch generated 0 new + 7 unchanged - 2 fixed = 7 total (was 9)
+1 💚checkstyle0m 14stez-plugins/tez-yarn-timeline-history: The patch generated 0 new + 44 unchanged - 1 fixed = 44 total (was 45)
+1 💚checkstyle0m 14stez-plugins/tez-history-parser: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4)
+1 💚checkstyle0m 13stez-tools/analyzers/job-analyzer: The patch generated 0 new + 2 unchanged - 2 fixed = 2 total (was 4)
+1 💚checkstyle0m 11stez-tools/tez-javadoc-tools: The patch generated 0 new + 2 unchanged - 2 fixed = 2 total (was 4)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc4m 7sthe patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚javadoc3m 48sthe patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚findbugs9m 58sthe patch passed
_ Other Tests _
+1 💚unit2m 18stez-api in the patch passed.
+1 💚unit0m 31stez-common in the patch passed.
+1 💚unit0m 43stez-runtime-internals in the patch passed.
+1 💚unit5m 59stez-runtime-library in the patch passed.
+1 💚unit1m 25stez-mapreduce in the patch passed.
+1 💚unit0m 20stez-examples in the patch passed.
+1 💚unit5m 22stez-dag in the patch passed.
+1 💚unit41m 0stez-tests in the patch passed.
+1 💚unit4m 15stez-ext-service-tests in the patch passed.
+1 💚unit1m 43stez-yarn-timeline-history in the patch passed.
+1 💚unit2m 31stez-history-parser in the patch passed.
+1 💚unit2m 54sjob-analyzer in the patch passed.
+1 💚unit0m 19stez-javadoc-tools in the patch passed.
+1 💚asflicense3m 28sThe patch does not generate ASF License warnings.
190m 33s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-197/6/artifact/out/Dockerfile
GITHUB PR#197
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux 5ced6759ba56 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 65f9ee3
Default JavaPrivate Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-197/6/testReport/
Max. process+thread count1448 (vs. ulimit of 5500)
modulesC: tez-api tez-common tez-runtime-internals tez-runtime-library tez-mapreduce tez-examples tez-dag tez-tests tez-ext-service-tests tez-plugins/tez-yarn-timeline-history tez-plugins/tez-history-parser tez-tools/analyzers/job-analyzer tez-tools/tez-javadoc-tools U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-197/6/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdogabstractdog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
I'm about to change the commit message to reflect that this commit includes lots of refactors other than final classes
thanks @ghanko , this is a great code quality improvement

@abstractdog
abstractdog merged commit 2fd7df4 into apache:masterNov 26, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ghanko@tez-yetus@abstractdog