Skip to content

TEZ-4406: Use Path.getFilesystem api to get the correct FileSystem object for given staging path - #201

Merged
rbalamohan merged 1 commit into
apache:masterfrom
guptanikhil007:tez_4406
Apr 25, 2022
Merged

TEZ-4406: Use Path.getFilesystem api to get the correct FileSystem object for given staging path#201
rbalamohan merged 1 commit into
apache:masterfrom
guptanikhil007:tez_4406

Conversation

@guptanikhil007

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Use Path.getFilesystem api to get the correct FileSystem object for given staging path

Why are the changes needed?

To prevent Wrong FS issue when the staging directory and warehouse root are on different storage locations and tez-conf size exceeds the IPC limit.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manual tests.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec19m 0sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep6m 11sMaven dependency ordering for branch
+1 💚mvninstall10m 59smaster passed
+1 💚compile2m 14smaster passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚compile2m 8smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle2m 8smaster passed
+1 💚javadoc2m 10smaster passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚javadoc1m 44smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗spotbugs1m 53sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs3m 50smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall1m 1sthe patch passed
+1 💚compile1m 13sthe patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚javac1m 13sthe patch passed
+1 💚compile1m 3sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac1m 3sthe patch passed
+1 💚checkstyle0m 18stez-api: The patch generated 0 new + 30 unchanged - 1 fixed = 30 total (was 31)
+1 💚checkstyle0m 25sThe patch passed checkstyle in tez-dag
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc1m 7sthe patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚javadoc1m 1sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚findbugs2m 52sthe patch passed
_ Other Tests _
+1 💚unit2m 26stez-api in the patch passed.
+1 💚unit5m 8stez-dag in the patch passed.
+1 💚asflicense0m 29sThe patch does not generate ASF License warnings.
69m 28s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-201/1/artifact/out/Dockerfile
GITHUB PR#201
JIRA IssueTEZ-4406
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux dcbe0adce207 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 627f330
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-201/1/testReport/
Max. process+thread count237 (vs. ulimit of 5500)
modulesC: tez-api tez-dag U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-201/1/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@guptanikhil007

Copy link
Copy Markdown
ContributorAuthor

@rbalamohan and @abstractdog
Can you please help with the review?

@rbalamohan

Copy link
Copy Markdown
Contributor

Thanks for the patch @guptanikhil007. Looks like this is a corner case scenario with large IPC limits.

Patch looks good to me. +1

@guptanikhil007

Copy link
Copy Markdown
ContributorAuthor

@rbalamohan Can you please merge this as well?
I don't have commit access.

@rbalamohan
rbalamohan merged commit 9f8d6fb into apache:masterApr 25, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@guptanikhil007@tez-yetus@rbalamohan