Uh oh!
There was an error while loading. Please reload this page.
TEZ-4428: Use protoc-jar-maven-plugin to generate protobuf classes - #218
Merged
Conversation
slachiewicz
approved these changes
Jun 8, 2022
tez-yetus
commented
Jun 8, 2022
(!) A patch to the testing environment has been detected. |
tez-yetus
commented
Jun 8, 2022
💔 -1 overall
This message was automatically generated. |
abstractdog
commented
Jun 9, 2022
Contributor
change looks good to me, 2 things to check:
|
mark-bathori
commented
Jun 9, 2022
ContributorAuthor
Thanks for checking the PR.
|
tez-yetus
commented
Jun 9, 2022
(!) A patch to the testing environment has been detected. |
martin-g
approved these changes
Jun 9, 2022
tez-yetus
commented
Jun 9, 2022
💔 -1 overall
This message was automatically generated. |
abstractdog
self-requested a review
June 21, 2022 07:32
basapuram-kumar pushed a commit
to acceldata-io/tez
that referenced
this pull request
Sep 26, 2025
…pache#218) (Mark Bathori reviewed by Martin Tzvetanov Grigorov, Sylwester Lachiewicz, Laszlo Bodor)
basapuram-kumar pushed a commit
to acceldata-io/tez
that referenced
this pull request
Sep 26, 2025
…pache#218) (Mark Bathori reviewed by Martin Tzvetanov Grigorov, Sylwester Lachiewicz, Laszlo Bodor)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the current protobuf handler plugin with
protoc-jar-maven-plugin. The plugin handles the platform detection, binary download and execution with the provided protoc version. Because of that all the custom scriptd can be removed which were handling these tasks (install-protobuf.shetc).The plugin also supports the use of other already installed versions of protoc in the system. It can be configured through the PROTOC_PATH environment variable or by using -Dprotoc.path parameter during build.
Based on this if there is no
protoCommandprovided then the plugin will download the protoc binary with version provided in${protobuf.version}, otherwise it will use the external protoc on the provided path.