Skip to content

TEZ-4385: Update checkstyle.xml and partially update the code - #219

Open
LA-Toth wants to merge 2 commits into
apache:masterfrom
LA-Toth:a/TEZ-4385
Open

TEZ-4385: Update checkstyle.xml and partially update the code#219
LA-Toth wants to merge 2 commits into
apache:masterfrom
LA-Toth:a/TEZ-4385

Conversation

@LA-Toth

Copy link
Copy Markdown
Contributor

As of now the codebase doesn't match the checkstyle configuration. I updated the config file to be sometimes stricter, sometimes more permissive compared to the previous version. As the code can't be updated in a single step, this pull request contains the simplest indentation changes (further PRs are needed).

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 13sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 14sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 258 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep6m 37sMaven dependency ordering for branch
+1 💚mvninstall10m 34smaster passed
+1 💚compile17m 33smaster passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚compile16m 7smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle22m 59smaster passed
+1 💚javadoc15m 34smaster passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚javadoc14m 17smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗spotbugs0m 52sUsed deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗findbugs0m 29sbranch/tez-build-tools no findbugs output file (findbugsXml.xml)
+0 🆗findbugs6m 6sroot in master has 2 extant findbugs warnings.
+0 🆗findbugs0m 50stez-tools/analyzers/job-analyzer in master has 4 extant findbugs warnings.
-1 ❌findbugs0m 33stez-tfile-parser in master failed.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall13m 11sthe patch passed
+1 💚compile17m 8sthe patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚javac17m 8sthe patch passed
+1 💚compile16m 7sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac16m 7sthe patch passed
+1 💚checkstyle0m 44shadoop-shim: The patch generated 0 new + 9 unchanged - 3 fixed = 9 total (was 12)
-0 ⚠️checkstyle1m 5stez-api: The patch generated 230 new + 731 unchanged - 446 fixed = 961 total (was 1177)
+1 💚checkstyle0m 28sThe patch passed checkstyle in tez-build-tools
-0 ⚠️checkstyle0m 37stez-common: The patch generated 39 new + 58 unchanged - 111 fixed = 97 total (was 169)
-0 ⚠️checkstyle0m 43stez-runtime-internals: The patch generated 87 new + 153 unchanged - 142 fixed = 240 total (was 295)
-0 ⚠️checkstyle1m 29stez-runtime-library: The patch generated 634 new + 1025 unchanged - 918 fixed = 1659 total (was 1943)
-0 ⚠️checkstyle1m 14stez-mapreduce: The patch generated 746 new + 554 unchanged - 411 fixed = 1300 total (was 965)
-0 ⚠️checkstyle0m 36stez-examples: The patch generated 19 new + 46 unchanged - 30 fixed = 65 total (was 76)
-0 ⚠️checkstyle1m 44stez-dag: The patch generated 1038 new + 1060 unchanged - 2229 fixed = 2098 total (was 3289)
-0 ⚠️checkstyle1m 1stez-tests: The patch generated 714 new + 249 unchanged - 946 fixed = 963 total (was 1195)
-0 ⚠️checkstyle0m 37stez-ext-service-tests: The patch generated 12 new + 53 unchanged - 71 fixed = 65 total (was 124)
-0 ⚠️checkstyle0m 36stez-plugins/tez-protobuf-history-plugin: The patch generated 23 new + 8 unchanged - 85 fixed = 31 total (was 93)
-0 ⚠️checkstyle0m 36stez-plugins/tez-yarn-timeline-history: The patch generated 10 new + 24 unchanged - 155 fixed = 34 total (was 179)
-0 ⚠️checkstyle0m 35stez-plugins/tez-yarn-timeline-history-with-acls: The patch generated 9 new + 20 unchanged - 8 fixed = 29 total (was 28)
-0 ⚠️checkstyle0m 34stez-plugins/tez-yarn-timeline-cache-plugin: The patch generated 1 new + 3 unchanged - 18 fixed = 4 total (was 21)
-0 ⚠️checkstyle0m 35stez-plugins/tez-yarn-timeline-history-with-fs: The patch generated 13 new + 15 unchanged - 69 fixed = 28 total (was 84)
-0 ⚠️checkstyle0m 40stez-plugins/tez-history-parser: The patch generated 49 new + 94 unchanged - 28 fixed = 143 total (was 122)
-0 ⚠️checkstyle0m 37stez-plugins/tez-aux-services: The patch generated 21 new + 33 unchanged - 68 fixed = 54 total (was 101)
-0 ⚠️checkstyle0m 39stez-tools/analyzers/job-analyzer: The patch generated 60 new + 36 unchanged - 58 fixed = 96 total (was 94)
-0 ⚠️checkstyle0m 34stez-tools/tez-javadoc-tools: The patch generated 9 new + 19 unchanged - 6 fixed = 28 total (was 25)
+1 💚checkstyle0m 31shadoop-shim-impls/hadoop-shim-2.8: The patch generated 0 new + 1 unchanged - 6 fixed = 1 total (was 7)
-0 ⚠️checkstyle4m 45sroot: The patch generated 3722 new + 4183 unchanged - 5816 fixed = 7905 total (was 9999)
+1 💚checkstyle0m 33sThe patch passed checkstyle in hadoop-shim-2.7
-0 ⚠️checkstyle0m 33stez-tools/tez-tfile-parser: The patch generated 1 new + 2 unchanged - 2 fixed = 3 total (was 4)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 3sThe patch has no ill-formed XML file.
+1 💚javadoc15m 20sthe patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚javadoc14m 12sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗findbugs0m 29stez-build-tools has no data from findbugs
-1 ❌findbugs0m 35stez-tfile-parser in the patch failed.
_ Other Tests _
+1 💚unit0m 39shadoop-shim in the patch passed.
+1 💚unit2m 28stez-api in the patch passed.
+1 💚unit0m 30stez-build-tools in the patch passed.
+1 💚unit0m 46stez-common in the patch passed.
+1 💚unit0m 58stez-runtime-internals in the patch passed.
+1 💚unit5m 18stez-runtime-library in the patch passed.
+1 💚unit1m 39stez-mapreduce in the patch passed.
+1 💚unit0m 36stez-examples in the patch passed.
+1 💚unit5m 22stez-dag in the patch passed.
+1 💚unit38m 55stez-tests in the patch passed.
+1 💚unit4m 18stez-ext-service-tests in the patch passed.
+1 💚unit0m 49stez-protobuf-history-plugin in the patch passed.
+1 💚unit1m 57stez-yarn-timeline-history in the patch passed.
+1 💚unit2m 11stez-yarn-timeline-history-with-acls in the patch passed.
+1 💚unit0m 39stez-yarn-timeline-cache-plugin in the patch passed.
+1 💚unit1m 56stez-yarn-timeline-history-with-fs in the patch passed.
+1 💚unit2m 44stez-history-parser in the patch passed.
+1 💚unit3m 6stez-aux-services in the patch passed.
+1 💚unit3m 5sjob-analyzer in the patch passed.
+1 💚unit0m 38stez-javadoc-tools in the patch passed.
+1 💚unit0m 39shadoop-shim-2.8 in the patch passed.
+1 💚unit69m 23sroot in the patch passed.
+1 💚unit0m 38shadoop-shim-2.7 in the patch passed.
+1 💚unit0m 38stez-tfile-parser in the patch passed.
+1 💚asflicense13m 19sThe patch does not generate ASF License warnings.
439m 12s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/Dockerfile
GITHUB PR#219
JIRA IssueTEZ-4385
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile xml
unameLinux 58dfa12ed2bd 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / e5a5578
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
findbugshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/branch-findbugs-tez-tools_tez-tfile-parser.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-api.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-common.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-runtime-internals.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-runtime-library.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-mapreduce.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-examples.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-dag.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-tests.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-ext-service-tests.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-plugins_tez-protobuf-history-plugin.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-plugins_tez-yarn-timeline-history.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-plugins_tez-yarn-timeline-history-with-acls.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-plugins_tez-yarn-timeline-cache-plugin.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-plugins_tez-yarn-timeline-history-with-fs.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-plugins_tez-history-parser.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-plugins_tez-aux-services.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-tools_analyzers_job-analyzer.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-tools_tez-javadoc-tools.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-root.txt
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/diff-checkstyle-tez-tools_tez-tfile-parser.txt
findbugshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/artifact/out/patch-findbugs-tez-tools_tez-tfile-parser.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/testReport/
Max. process+thread count2089 (vs. ulimit of 5500)
modulesC: hadoop-shim tez-api tez-build-tools tez-common tez-runtime-internals tez-runtime-library tez-mapreduce tez-examples tez-dag tez-tests tez-ext-service-tests tez-plugins/tez-protobuf-history-plugin tez-plugins/tez-yarn-timeline-history tez-plugins/tez-yarn-timeline-history-with-acls tez-plugins/tez-yarn-timeline-cache-plugin tez-plugins/tez-yarn-timeline-history-with-fs tez-plugins/tez-history-parser tez-plugins/tez-aux-services tez-tools/analyzers/job-analyzer tez-tools/tez-javadoc-tools hadoop-shim-impls/hadoop-shim-2.8 . hadoop-shim-impls/hadoop-shim-2.7 tez-tools/tez-tfile-parser U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-219/1/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdogabstractdog changed the title TEZ-4385: Update checkstyle.xml and partially update teh codeTEZ-4385: Update checkstyle.xml and partially update the codeJun 10, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@LA-Toth@tez-yetus