Skip to content

TEZ-3322: Add Apache license to the generated tez-configuration-template files - #230

Merged
ayushtkn merged 1 commit into
apache:masterfrom
abstractdog:TEZ-3322
Aug 18, 2024
Merged

TEZ-3322: Add Apache license to the generated tez-configuration-template files#230
ayushtkn merged 1 commit into
apache:masterfrom
abstractdog:TEZ-3322

Conversation

@abstractdog

Copy link
Copy Markdown
Contributor

tested:
built tez-javadoc-tools procject

cd tez-runtime-library
mvn site

checked ./target/site/apidocs/configs/tez-runtime-default-template.xml

@abstractdog
abstractdog requested a review from sidsethJuly 9, 2022 10:00
@abstractdog

Copy link
Copy Markdown
ContributorAuthor

I just picked this up while creating tez 0.10.2, can you please review @sidseth ?

@tez-yetus

This comment was marked as outdated.

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall15m 48smaster passed
+1 💚compile0m 44smaster passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚compile0m 43smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚checkstyle1m 19smaster passed
+1 💚javadoc0m 56smaster passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚javadoc0m 41smaster passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗spotbugs1m 17sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs1m 15smaster passed
_ Patch Compile Tests _
+1 💚mvninstall0m 15sthe patch passed
+1 💚compile0m 15sthe patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚javac0m 15sthe patch passed
+1 💚compile0m 13sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚javac0m 13sthe patch passed
-0 ⚠️checkstyle0m 10stez-tools/tez-javadoc-tools: The patch generated 1 new + 0 unchanged - 1 fixed = 1 total (was 1)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 13sthe patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚javadoc0m 12sthe patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚findbugs0m 29sthe patch passed
_ Other Tests _
+1 💚unit0m 14stez-javadoc-tools in the patch passed.
+1 💚asflicense0m 17sThe patch does not generate ASF License warnings.
25m 13s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-230/2/artifact/out/Dockerfile
GITHUB PR#230
JIRA IssueTEZ-3322
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux 0ac630e8179a 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / a192ec4
Default JavaPrivate Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
checkstylehttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-230/2/artifact/out/diff-checkstyle-tez-tools_tez-javadoc-tools.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-230/2/testReport/
Max. process+thread count95 (vs. ulimit of 5500)
modulesC: tez-tools/tez-javadoc-tools U: tez-tools/tez-javadoc-tools
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-230/2/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ayushtknayushtkn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

thanks @ayushtkn for the review!
can you take a look at this @rbalamohan , @sidseth please?

@ayushtkn
ayushtkn merged commit a66c903 into apache:masterAug 18, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@abstractdog@tez-yetus@ayushtkn