Skip to content

TEZ-4447: Collect VertexStatus properly when DAGClientServer is not used (local mode without network) - #239

Merged
abstractdog merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4447
Sep 14, 2022
Merged

TEZ-4447: Collect VertexStatus properly when DAGClientServer is not used (local mode without network)#239
abstractdog merged 1 commit into
apache:masterfrom
abstractdog:TEZ-4447

Conversation

@abstractdog

Copy link
Copy Markdown
Contributor

No description provided.

@tez-yetus

This comment was marked as outdated.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 7sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep4m 41sMaven dependency ordering for branch
+1 💚mvninstall11m 10smaster passed
+1 💚compile3m 37smaster passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚compile3m 18smaster passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚checkstyle3m 1smaster passed
+1 💚javadoc3m 24smaster passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚javadoc3m 7smaster passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+0 🆗spotbugs0m 55sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs5m 58smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for patch
+1 💚mvninstall1m 55sthe patch passed
+1 💚compile2m 13sthe patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚javac2m 13sthe patch passed
+1 💚compile1m 54sthe patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚javac1m 54sthe patch passed
+1 💚checkstyle1m 18sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc1m 46sthe patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚javadoc1m 40sthe patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚findbugs4m 48sthe patch passed
_ Other Tests _
+1 💚unit2m 16stez-api in the patch passed.
+1 💚unit4m 58stez-runtime-library in the patch passed.
+1 💚unit1m 20stez-mapreduce in the patch passed.
+1 💚unit5m 8stez-dag in the patch passed.
+1 💚unit37m 53stez-tests in the patch passed.
+1 💚asflicense1m 5sThe patch does not generate ASF License warnings.
109m 44s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-239/3/artifact/out/Dockerfile
GITHUB PR#239
JIRA IssueTEZ-4447
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux 37efe7c97736 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 55b6031
Default JavaPrivate Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-239/3/testReport/
Max. process+thread count1186 (vs. ulimit of 5500)
modulesC: tez-api tez-runtime-library tez-mapreduce tez-dag tez-tests U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-239/3/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@rbalamohan

Copy link
Copy Markdown
Contributor

I went through the changes. Core change is related to how "getVertexStatus" is obtained for DAGClientImplLocal.

LGTM. +1.

@abstractdog

Copy link
Copy Markdown
ContributorAuthor

yes, absolutely, thanks @rbalamohan for the review!
I also tested this in the scope of HIVE-26445

@abstractdog
abstractdog merged commit de88f2a into apache:masterSep 14, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@abstractdog@tez-yetus@rbalamohan