Skip to content

TEZ-4454: remove extra semicolons - #246

Merged
abstractdog merged 1 commit into
apache:masterfrom
slfan1989:TEZ-4454
Nov 9, 2022
Merged

TEZ-4454: remove extra semicolons#246
abstractdog merged 1 commit into
apache:masterfrom
slfan1989:TEZ-4454

Conversation

@slfan1989

@slfan1989slfan1989 commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

JIRA: TEZ-4454: remove extra commas.

While reading the code, I found that there are extra commas in the code, I searched the whole project and removed the extra commas.

@tez-yetus

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec36m 35sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 3 new or modified test files.
_ master Compile Tests _
+0 🆗mvndep6m 1sMaven dependency ordering for branch
+1 💚mvninstall11m 15smaster passed
+1 💚compile2m 57smaster passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚compile2m 43smaster passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚checkstyle2m 40smaster passed
+1 💚javadoc2m 48smaster passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚javadoc2m 32smaster passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+0 🆗spotbugs0m 54sUsed deprecated FindBugs config; considering switching to SpotBugs.
+1 💚findbugs5m 5smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall1m 35sthe patch passed
+1 💚compile1m 47sthe patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚javac1m 47sthe patch passed
+1 💚compile1m 30sthe patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚javac1m 30sthe patch passed
+1 💚checkstyle0m 13sThe patch passed checkstyle in tez-api
+1 💚checkstyle0m 19stez-runtime-library: The patch generated 0 new + 137 unchanged - 2 fixed = 137 total (was 139)
+1 💚checkstyle0m 26stez-dag: The patch generated 0 new + 281 unchanged - 3 fixed = 281 total (was 284)
+1 💚checkstyle0m 13stez-tests: The patch generated 0 new + 43 unchanged - 2 fixed = 43 total (was 45)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc1m 28sthe patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚javadoc1m 24sthe patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚findbugs4m 8sthe patch passed
_ Other Tests _
+1 💚unit2m 13stez-api in the patch passed.
+1 💚unit5m 26stez-runtime-library in the patch passed.
+1 💚unit5m 9stez-dag in the patch passed.
+1 💚unit40m 56stez-tests in the patch passed.
+1 💚asflicense0m 53sThe patch does not generate ASF License warnings.
142m 4s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-246/1/artifact/out/Dockerfile
GITHUB PR#246
JIRA IssueTEZ-4454
Optional Testsdupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
unameLinux bb3c9bb0f70e 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 8ebc4b0
Default JavaPrivate Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-246/1/testReport/
Max. process+thread count1217 (vs. ulimit of 5500)
modulesC: tez-api tez-runtime-library tez-dag tez-tests U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-246/1/console
versionsgit=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989

Copy link
Copy Markdown
ContributorAuthor

@abstractdog Can you help review this pr? Thank you very much!

@abstractdog

Copy link
Copy Markdown
Contributor

LGTM +1
fixing this to "semicolons" instead of "commas"

@abstractdogabstractdog changed the title TEZ-4454: remove extra commas.TEZ-4454: remove extra semicolonsNov 4, 2022
@abstractdog
abstractdog self-requested a review November 4, 2022 06:52
@abstractdog
abstractdog merged commit 8bb27b8 into apache:masterNov 9, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@slfan1989@tez-yetus@abstractdog