Skip to content

TEZ-4169: Decouple from Hadoop's jackson version and shade the latest… - #247

Open
abstractdog wants to merge 1 commit into
apache:masterfrom
abstractdog:TEZ-4169
Open

TEZ-4169: Decouple from Hadoop's jackson version and shade the latest…#247
abstractdog wants to merge 1 commit into
apache:masterfrom
abstractdog:TEZ-4169

Conversation

@abstractdog

Copy link
Copy Markdown
Contributor

… in Tez

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec33m 0sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗mvndep6m 47sMaven dependency ordering for branch
+1 💚mvninstall10m 19smaster passed
+1 💚compile9m 46smaster passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚compile9m 14smaster passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚javadoc9m 10smaster passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚javadoc8m 32smaster passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
_ Patch Compile Tests _
+0 🆗mvndep0m 37sMaven dependency ordering for patch
+1 💚mvninstall7m 45sthe patch passed
+1 💚compile9m 36sthe patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚javac9m 36sthe patch passed
+1 💚compile9m 16sthe patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚javac9m 16sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 14sThe patch has no ill-formed XML file.
+1 💚javadoc8m 56sthe patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚javadoc8m 15sthe patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
_ Other Tests _
+1 💚unit2m 43stez-api in the patch passed.
+1 💚unit1m 44stez-mapreduce in the patch passed.
+1 💚unit42m 2stez-tests in the patch passed.
+1 💚unit4m 36stez-ext-service-tests in the patch passed.
+1 💚unit0m 50stez-protobuf-history-plugin in the patch passed.
+1 💚unit2m 2stez-yarn-timeline-history in the patch passed.
+1 💚unit2m 12stez-yarn-timeline-history-with-acls in the patch passed.
+1 💚unit2m 0stez-yarn-timeline-history-with-fs in the patch passed.
+1 💚unit2m 50stez-history-parser in the patch passed.
+1 💚unit3m 16sjob-analyzer in the patch passed.
-1 ❌unit10m 27sroot in the patch failed.
+1 💚asflicense7m 27sThe patch does not generate ASF License warnings.
216m 10s
ReasonTests
Failed junit teststez.runtime.library.common.shuffle.TestShuffleUtils
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-247/1/artifact/out/Dockerfile
GITHUB PR#247
JIRA IssueTEZ-4169
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux 0529c162af78 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitypersonality/tez.sh
git revisionmaster / 8ebc4b0
Default JavaPrivate Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
unithttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-247/1/artifact/out/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-247/1/testReport/
Max. process+thread count1755 (vs. ulimit of 5500)
modulesC: tez-api tez-mapreduce tez-tests tez-ext-service-tests tez-plugins/tez-protobuf-history-plugin tez-plugins/tez-yarn-timeline-history tez-plugins/tez-yarn-timeline-history-with-acls tez-plugins/tez-yarn-timeline-history-with-fs tez-plugins/tez-history-parser tez-tools/analyzers/job-analyzer . U: .
Console outputhttps://ci-hadoop.apache.org/job/tez-multibranch/job/PR-247/1/console
versionsgit=2.25.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ayushtkn

Copy link
Copy Markdown
Member

The latest hadoop code has higher jackson version.
https://github.com/apache/hadoop/blob/trunk/hadoop-project/pom.xml#L71-L73
btw. jackson & jersey are bit messy, is the reason behind shading was older version from hadoop, and we wanted to move forward?

Well, jackson in hadoop code does seems to be used in hdfs-client, and in RBF(hdfs federation), maven classpaths during tests and in the actual differ in some cases, not sure how safe it is, if there is any interaction b/w any Hadoop method which takes any jackson class as an argument, it would create noise, typical problems, with shading.....

if only version is an issue, hadoop 3.3.5 is out and I am attempting an upgrade to that and it has 2.12 jackson

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@abstractdog@tez-yetus@ayushtkn